You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/08/31 16:15:51 UTC

[GitHub] [incubator-eventmesh] horoc opened a new pull request, #1198: [ISSUE #1194] Fix FileWebHookConfigOperation insert error

horoc opened a new pull request, #1198:
URL: https://github.com/apache/incubator-eventmesh/pull/1198

   <!--
   ### Contribution Checklist
   
     - Name the pull request in the form "[ISSUE #XXXX] Title of the pull request", 
       where *XXXX* should be replaced by the actual issue number.
       Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
   
     - Fill out the template below to describe the changes contributed by the pull request. 
       That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue. 
       Please do not mix up code from multiple issues.
     
     - Each commit in the pull request should have a meaningful commit message.
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, 
       leaving only the filled out template below.
   
   (The sections below can be removed for hotfixes of typos)
   -->
   
   <!--
   (If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Cloese #<XXX>`.)
   -->
   
   Fix FileWebHookConfigOperation insert error
   
   ### Motivation
   
   #1194 
   
   
   ### Modifications
   
   - Fix the FileLock release exception.
   - Fix queryWebHookConfigByManufacturer iterating condition, ```endIndex``` should be the inclusive bound.
   - Add unit test of insertWebHookConfig  
   
   
   ### Documentation
   
   None


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #1198: [ISSUE #1194] Fix FileWebHookConfigOperation insert error

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on PR #1198:
URL: https://github.com/apache/incubator-eventmesh/pull/1198#issuecomment-1234146776

   @horoc please check the CI fail tasks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] horoc commented on pull request #1198: [ISSUE #1194] Fix FileWebHookConfigOperation insert error

Posted by GitBox <gi...@apache.org>.
horoc commented on PR #1198:
URL: https://github.com/apache/incubator-eventmesh/pull/1198#issuecomment-1234359424

   > @horoc please check the CI fail tasks.
   
   Fixed, please help to review the changes, lots of thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #1198: [ISSUE #1194] Fix FileWebHookConfigOperation insert error

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on PR #1198:
URL: https://github.com/apache/incubator-eventmesh/pull/1198#issuecomment-1233650998

   @horoc there are fail CI taslks needed to be fixed before merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #1198: [ISSUE #1194] Fix FileWebHookConfigOperation insert error

Posted by GitBox <gi...@apache.org>.
qqeasonchen merged PR #1198:
URL: https://github.com/apache/incubator-eventmesh/pull/1198


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #1198: [ISSUE #1194] Fix FileWebHookConfigOperation insert error

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1198:
URL: https://github.com/apache/incubator-eventmesh/pull/1198#issuecomment-1234350586

   # [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1198](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cc22f39) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/80105641bc9050218823aab8479748e368d64b08?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8010564) will **decrease** coverage by `0.13%`.
   > The diff coverage is `20.00%`.
   
   > :exclamation: Current head cc22f39 differs from pull request most recent head 261f35a. Consider uploading reports for the commit 261f35a to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1198      +/-   ##
   ============================================
   - Coverage     10.31%   10.18%   -0.14%     
   + Complexity      666      662       -4     
   ============================================
     Files           382      385       +3     
     Lines         23640    23820     +180     
     Branches       2619     2646      +27     
   ============================================
   - Hits           2438     2425      -13     
   - Misses        20992    21175     +183     
   - Partials        210      220      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...mmon/protocol/grpc/protos/ConsumerServiceGrpc.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL3Byb3Rvcy9Db25zdW1lclNlcnZpY2VHcnBjLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...mon/protocol/grpc/protos/HeartbeatServiceGrpc.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL3Byb3Rvcy9IZWFydGJlYXRTZXJ2aWNlR3JwYy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...mon/protocol/grpc/protos/PublisherServiceGrpc.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL3Byb3Rvcy9QdWJsaXNoZXJTZXJ2aWNlR3JwYy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...e/admin/handler/QueryWebHookConfigByIdHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUXVlcnlXZWJIb29rQ29uZmlnQnlJZEhhbmRsZXIuamF2YQ==) | `26.66% <0.00%> (ø)` | |
   | [...org/apache/eventmesh/runtime/trace/TraceUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3RyYWNlL1RyYWNlVXRpbHMuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...mesh/webhook/admin/FileWebHookConfigOperation.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXdlYmhvb2svZXZlbnRtZXNoLXdlYmhvb2stYWRtaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC93ZWJob29rL2FkbWluL0ZpbGVXZWJIb29rQ29uZmlnT3BlcmF0aW9uLmphdmE=) | `45.00% <25.00%> (ø)` | |
   | [...pache/eventmesh/common/file/FileChangeContext.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9maWxlL0ZpbGVDaGFuZ2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tmesh/registry/etcd/factory/EtcdClientWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJlZ2lzdHJ5LXBsdWdpbi9ldmVudG1lc2gtcmVnaXN0cnktZXRjZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3JlZ2lzdHJ5L2V0Y2QvZmFjdG9yeS9FdGNkQ2xpZW50V3JhcHBlci5qYXZh) | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
   | [...rg/apache/eventmesh/common/file/WatchFileTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9maWxlL1dhdGNoRmlsZVRhc2suamF2YQ==) | `28.07% <0.00%> (-29.83%)` | :arrow_down: |
   | [...e/eventmesh/registry/etcd/factory/EtcdLeaseId.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJlZ2lzdHJ5LXBsdWdpbi9ldmVudG1lc2gtcmVnaXN0cnktZXRjZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3JlZ2lzdHJ5L2V0Y2QvZmFjdG9yeS9FdGNkTGVhc2VJZC5qYXZh) | `35.00% <0.00%> (-15.00%)` | :arrow_down: |
   | ... and [12 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/1198/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org