[GitHub] kaijianding commented on a change in pull request #5541: Added merge/buffer metric to print buffer pool size every minute

[GitBox <gi...@apache.org>]

kaijianding commented on a change in pull request #5541: Added merge/buffer metric to print buffer pool size every minute
URL: https://github.com/apache/incubator-druid/pull/5541#discussion_r209455739
 
 

 ##########
 File path: docs/content/operations/metrics.md
 ##########
 @@ -37,6 +37,7 @@ Available Metrics
 |`query/success/count`|number of queries successfully processed|This metric is only available if the QueryCountStatsMonitor module is included.||
 |`query/failed/count`|number of failed queries|This metric is only available if the QueryCountStatsMonitor module is included.||
 |`query/interrupted/count`|number of queries interrupted due to cancellation or timeout|This metric is only available if the QueryCountStatsMonitor module is included.||
+|`query/merge/buffersUsed`|number of merge buffers allocated to broker while performing groupBy merge queries|||
 
 Review comment:
   I guess the DruidProcessingModule.getMergeBufferPool() is called GroupByStrategyV2, and GroupByStrategyV2 is called in historical and realtime when group by query, so this metric also should be documented in historical and realtime section?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org