[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #641: PHOENIX-5589 GlobalIndexChecker does not populate global index relate…

[GitBox <gi...@apache.org>]

ChinmaySKulkarni commented on a change in pull request #641: PHOENIX-5589 GlobalIndexChecker does not populate global index relate…
URL: https://github.com/apache/phoenix/pull/641#discussion_r350976740
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
 ##########
 @@ -958,6 +958,13 @@ public static void setScanAttributesForIndexReadRepair(Scan scan, PTable table,
             // This index table must be being deleted. No need to set the scan attributes
             return;
         }
+        // MetaDataClient modifies the index table name for view indexes if the parent view of an index has a child
+        // view. This, we need to recreate a PTable object with the correct table name for the rest of this code to work
+        if (table.getName().getString().contains(QueryConstants.CHILD_VIEW_INDEX_NAME_SEPARATOR)) {
 
 Review comment:
   This should check if table is view index..maybe you can use 'table.getViewIndexId() != null`?
   I believe we disallow using '#' in user-defined names..you get:
   
   ```
   java.lang.IllegalArgumentException: Illegal character code:35, <#> at 3. User-space table qualifiers can only contain 'alphanumeric characters': i.e. [a-zA-Z_0-9-.]:
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services