You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/09/22 18:21:58 UTC
Review Request 62509: Added `intptr_t` constructor for `WindowsFD`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62509/
-----------------------------------------------------------
Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff.
Bugs: MESOS-7992
https://issues.apache.org/jira/browse/MESOS-7992
Repository: mesos
Description
-------
This is the inverse of the existing explicit cast required for the
socket type used by libevent on Windows.
Diffs
-----
3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7
3rdparty/stout/include/stout/os/windows/fd.hpp ae2db27154e694f319dafe2e04c01d55c42179de
Diff: https://reviews.apache.org/r/62509/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 62509: Added `intptr_t` constructor for
`WindowsFD`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62509/#review186019
-----------------------------------------------------------
PASS: Mesos patch 62509 was successfully built and tested.
Reviews applied: `['62508', '62509']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62509
- Mesos Reviewbot Windows
On Sept. 22, 2017, 6:21 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62509/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 6:21 p.m.)
>
>
> Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-7992
> https://issues.apache.org/jira/browse/MESOS-7992
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the inverse of the existing explicit cast required for the
> socket type used by libevent on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7
> 3rdparty/stout/include/stout/os/windows/fd.hpp ae2db27154e694f319dafe2e04c01d55c42179de
>
>
> Diff: https://reviews.apache.org/r/62509/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 62509: Added `intptr_t` constructor for
`WindowsFD`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Oct. 2, 2017, 1:23 p.m., Joseph Wu wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 516-518 (patched)
> > <https://reviews.apache.org/r/62509/diff/1/?file=1832914#file1832914line516>
> >
> > There should be two separate conditionals here:
> >
> > 1) `if (ENABLE_SSL)` which appends the `CMAKE_USE_OPENSSL` option.
> >
> > 2) `if (OPENSSL_ROOT_DIR)` which passes the hint over to curl.
> >
> > ---
> >
> > The CMake changes here don't really fit in with the contents of the rest of the patch. Consider moving these lines into a subsequent patch, like https://reviews.apache.org/r/62511/
> >
> > ---
> >
> > Nit: Newline before and after this block.
Agreed, fixing.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62509/#review186877
-----------------------------------------------------------
On Sept. 22, 2017, 11:21 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62509/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 11:21 a.m.)
>
>
> Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-7992
> https://issues.apache.org/jira/browse/MESOS-7992
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the inverse of the existing explicit cast required for the
> socket type used by libevent on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7
> 3rdparty/stout/include/stout/os/windows/fd.hpp ae2db27154e694f319dafe2e04c01d55c42179de
>
>
> Diff: https://reviews.apache.org/r/62509/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 62509: Added `intptr_t` constructor for
`WindowsFD`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62509/#review186877
-----------------------------------------------------------
Socket modification LGTM.
3rdparty/CMakeLists.txt
Lines 516-518 (patched)
<https://reviews.apache.org/r/62509/#comment263758>
There should be two separate conditionals here:
1) `if (ENABLE_SSL)` which appends the `CMAKE_USE_OPENSSL` option.
2) `if (OPENSSL_ROOT_DIR)` which passes the hint over to curl.
---
The CMake changes here don't really fit in with the contents of the rest of the patch. Consider moving these lines into a subsequent patch, like https://reviews.apache.org/r/62511/
---
Nit: Newline before and after this block.
- Joseph Wu
On Sept. 22, 2017, 11:21 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62509/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 11:21 a.m.)
>
>
> Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-7992
> https://issues.apache.org/jira/browse/MESOS-7992
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the inverse of the existing explicit cast required for the
> socket type used by libevent on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7
> 3rdparty/stout/include/stout/os/windows/fd.hpp ae2db27154e694f319dafe2e04c01d55c42179de
>
>
> Diff: https://reviews.apache.org/r/62509/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 62509: Added `intptr_t` constructor for
`WindowsFD`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62509/#review187704
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Oct. 2, 2017, 4:45 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62509/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 4:45 p.m.)
>
>
> Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-7992
> https://issues.apache.org/jira/browse/MESOS-7992
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the inverse of the existing explicit cast required for the
> socket type used by libevent on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/fd.hpp 8f31f4666431cc75b9c4687c2ef0a6341e5b92f0
>
>
> Diff: https://reviews.apache.org/r/62509/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 62509: Added `intptr_t` constructor for
`WindowsFD`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62509/
-----------------------------------------------------------
(Updated Oct. 2, 2017, 4:45 p.m.)
Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff.
Changes
-------
Removed CMake changes.
Bugs: MESOS-7992
https://issues.apache.org/jira/browse/MESOS-7992
Repository: mesos
Description
-------
This is the inverse of the existing explicit cast required for the
socket type used by libevent on Windows.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/windows/fd.hpp 8f31f4666431cc75b9c4687c2ef0a6341e5b92f0
Diff: https://reviews.apache.org/r/62509/diff/2/
Changes: https://reviews.apache.org/r/62509/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer