You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Taragolis (via GitHub)" <gi...@apache.org> on 2023/02/07 19:45:25 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #29408: Improve health checks in example docker-compose and clarify usage
Taragolis opened a new pull request, #29408:
URL: https://github.com/apache/airflow/pull/29408
This PR include some improvements and clarifications:
- Based on my experience use simple http scheduler healthcheck required less resources rather run in shell airflow cli.
- Added grace period for healthchecks, which also reduce resource usage during startup airflow services
- Increase healthchecks intervals, for the same reason - reduce resource usage.
- Set port mapping as string
- Added clarification about `_PIP_ADDITIONAL_REQUIREMENTS`, users might ignore warning during services startup however they should noticed it when add modification in docker-compose.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29408: Improve health checks in example docker-compose and clarify usage
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29408:
URL: https://github.com/apache/airflow/pull/29408#issuecomment-1422223383
Tested it locally additionally. Looks good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BasPH commented on a diff in pull request #29408: Improve health checks in example docker-compose and clarify usage
Posted by "BasPH (via GitHub)" <gi...@apache.org>.
BasPH commented on code in PR #29408:
URL: https://github.com/apache/airflow/pull/29408#discussion_r1099923692
##########
docs/apache-airflow/howto/docker-compose/docker-compose.yaml:
##########
@@ -36,11 +36,16 @@
# _AIRFLOW_WWW_USER_PASSWORD - Password for the administrator account (if requested).
# Default: airflow
# _PIP_ADDITIONAL_REQUIREMENTS - Additional PIP requirements to add when starting all containers.
+# This option ONLY for a quick checks. Adding requirements at container
+# startup is fragile and is done EVERY TIME when service,
+# which is use default Airflow entrypoint script, started.
+# Instead, build a custom image or extend official image as described in
+# https://airflow.apache.org/docs/docker-stack/build.html
Review Comment:
```suggestion
# Use this option ONLY for quick checks. Installing requirements at container
# startup is done EVERY TIME the service is started.
# A better way is to build a custom image or extend the official image as described in
# https://airflow.apache.org/docs/docker-stack/build.html.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis merged pull request #29408: Improve health checks in example docker-compose and clarify usage
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis merged PR #29408:
URL: https://github.com/apache/airflow/pull/29408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org