[GitHub] [tvm] areusch commented on a diff in pull request #12028: [WIP][Pylint] Making frontend tests pylint compliant

[GitBox <gi...@apache.org>]

areusch commented on code in PR #12028:
URL: https://github.com/apache/tvm/pull/12028#discussion_r918374814


##########
tests/python/frontend/caffe/test_forward.py:
##########
@@ -37,9 +32,13 @@
 import tvm
 import tvm.testing
 from tvm import relay
-from tvm.contrib import utils, graph_executor
+from tvm.contrib import graph_executor
 from tvm.contrib.download import download_testdata
 
+os.environ["GLOG_minloglevel"] = "2"

Review Comment:
   is this one needed?



##########
tests/python/frontend/darknet/test_forward.py:
##########
@@ -23,16 +24,16 @@
 """
 import numpy as np
 import tvm
-from tvm import te
 from tvm.contrib import graph_executor
 from tvm.contrib.download import download_testdata
 
-download_testdata.__test__ = False
 from tvm.relay.testing.darknet import LAYERTYPE
 from tvm.relay.testing.darknet import __darknetffi__
 from tvm.relay.frontend.darknet import ACTIVATION
 from tvm import relay
 
+download_testdata.__test__ = False

Review Comment:
   is this needed? 



##########
tests/python/frontend/coreml/test_forward.py:
##########
@@ -827,10 +845,10 @@ def test_can_build_keras_to_coreml_to_relay():
 
 
 if __name__ == "__main__":
-    test_forward_AddLayerParams()
-    test_forward_ConcatLayerParams()
-    test_forward_MultiplyLayerParams()
-    test_forward_UpsampleLayerParams()
+    test_forward_add_layer_params

Review Comment:
   tvm.testing.main() here



##########
tests/python/frontend/tflite/test_forward.py:
##########
@@ -4978,6 +5015,8 @@ def test_forward_nms_v5():
 # Main
 # ----
 if __name__ == "__main__":
+    test_all_elemwise()

Review Comment:
   tvm.testing.main()



##########
tests/python/frontend/coreml/test_forward.py:
##########
@@ -422,6 +427,7 @@ def verify_unary_sqrt(input_dim):
 
 
 def verify_unary_rsqrt(input_dim, epsilon=0):
+    """Unary rsqrt"""

Review Comment:
   maybe as a stand-in here, you could just repeat the test name verbatim? it'd be great to avoid abbreviating so that we continue to refer to each unit test with exactly one name



##########
tests/python/frontend/keras/test_forward.py:
##########
@@ -14,21 +14,21 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+# pylint: disable=invalid-name, redefined-outer-name, missing-function-docstring

Review Comment:
   could you say why you're disabling lint when you do that? also, just a gentle push to try and avoid doing that unless theres an intractable problem here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org