[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41094: [SPARK-43413][SQL] Fix IN subquery ListQuery nullability

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #41094:
URL: https://github.com/apache/spark/pull/41094#discussion_r1187975843


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BinaryComparisonSimplificationSuite.scala:
##########
@@ -228,4 +228,31 @@ class BinaryComparisonSimplificationSuite extends PlanTest {
 
     checkCondition(nullableRelation, $"a" <=> nullLit, $"a".isNull)
   }
+
+  test("IN subquery nullability") {

Review Comment:
   Could you add a test prefix please, @jchen5 ?
   ```scala
   - test("IN subquery nullability") {
   + test("SPARK-43413: IN subquery nullability") {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org