[jira] Updated: (HDFS-132) Namenode in Safemode reports to Simon non-zero number of deleted files during startup

["Suresh Srinivas (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HDFS-132:
---------------------------------

    Attachment: HDFS-132.patch

Changes:
# FSDirectory.java
#* Removed metrics with context name "dfs" and record name "FSDirectory". This was being used just to track files deleted. Moved the metrics for files deleted to NameNodeMetrics.
#* Not very happy with introducing an argument logReplay in unprotectedDelete and unprotectedRename to differentiate an operation while replaying edits log from user operation. The assumption in the code is - unprotectedXXX is called for both regular operation and operation while replaying edits. However, returning number of files deleted from these methods seems like a lot more change and the method signature will not be clean either. 
# TestNameNodeMetrics.java - Removed importing org.mortbay.log.Log. Also cleaned up the code a bit to get rid of some warnings.

Note removing metrics record "FSDirectory" is an incompatible change.

> Namenode in Safemode reports to Simon non-zero number of deleted files during startup
> -------------------------------------------------------------------------------------
>
>                 Key: HDFS-132
>                 URL: https://issues.apache.org/jira/browse/HDFS-132
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Hairong Kuang
>         Attachments: HDFS-132.patch
>
>
> Currently when a namenode starts up it may call "delete" when loading edits. But metrics file_deleted is collected and reported in FSDirectory where it does not and is not able to check if namenode is in safemode. So from the monitoring UI, we see non-zero number of files deleted.
> A possible fix is to have delete to return the number of files deleted and then the metrics is collected and reported at NameNode the same as other namenode metrics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.