You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ayush Saxena (Jira)" <ji...@apache.org> on 2023/09/21 20:47:00 UTC
[jira] [Commented] (HADOOP-16062) Add ability to disable Configuration reload registry
[ https://issues.apache.org/jira/browse/HADOOP-16062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767724#comment-17767724 ]
Ayush Saxena commented on HADOOP-16062:
---------------------------------------
[~zabetak] found this ticket while investigating some memory issue in Hive & I see it isn't committed yet, Going through the ticket, I don't find any objections around this.
[~kgyrtkirk] Will you be able to create a PR for this? Patches don't trigger jenkins now.
Regarding the patch
{code:java}
+ public static synchronized void setConfigurationRegistryEnabled(boolean enable) {
+ if (enable) {
+ REGISTRY = new WeakHashMap<Configuration, Object>(); {code}
I don't think we should do {{new WeakHashMap<Configuration, Object>();}} only if {{REGISTRY}} is {{null}} else this will overwrite the map if it was already enabled.
> Add ability to disable Configuration reload registry
> ----------------------------------------------------
>
> Key: HADOOP-16062
> URL: https://issues.apache.org/jira/browse/HADOOP-16062
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Attachments: HADOOP-16062.01.patch, jxray_registry.png
>
>
> In Hive we see that after an extensive amount of usage there are a lot of Configuration objects not fully reclaimed because of Configuration's REGISTRY weak hashmap.
> https://github.com/apache/hadoop/blob/abde1e1f58d5b699e4b8e460cff68e154738169b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java#L321
> !jxray_registry.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org