You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mushketyk <gi...@git.apache.org> on 2016/08/21 08:49:38 UTC
[GitHub] flink pull request #2396: [FLINK-4395][cep] Eager processing of late arrival...
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2396
[FLINK-4395][cep] Eager processing of late arrivals in CEP operator
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mushketyk/flink eager-cep
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2396.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2396
----
commit a2a150dde32c1fc54f8f7fa2e124c40b764c016f
Author: Ivan Mushketyk <iv...@gmail.com>
Date: 2016-08-20T22:44:10Z
[FLINK-4395][cep] Replace isProcessingTime field with more expressive ProcessingType enum
commit 79f1754655869bd18440260e7f52c4769fc690fe
Author: Ivan Mushketyk <iv...@gmail.com>
Date: 2016-08-20T23:48:48Z
[FLINK-4395][cep] Eager processing of late arrivals in CEP operator
commit 8ca5b16919bec76bb936b3d8f33018159306bc5b
Author: Ivan Mushketyk <iv...@gmail.com>
Date: 2016-08-21T00:12:15Z
[FLINK-4395][cep] Minor refactoring
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2396: [FLINK-4395][cep] Eager processing of late arrivals in CE...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2396
Hi @chermenin ,
Sure, I'll do it tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2396: [FLINK-4395][cep] Eager processing of late arrivals in CE...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2396
Hi @chermenin,
To avoid rebasing this PR multiple times I'll wait until Till or another core reviewer will be available to review and merge this pull request.
Feel free to review it though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2396: [FLINK-4395][cep] Eager processing of late arrivals in CE...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2396
Hi @kl0u,
I've rebased the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2396: [FLINK-4395][cep] Eager processing of late arrival...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk closed the pull request at:
https://github.com/apache/flink/pull/2396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2396: [FLINK-4395][cep] Eager processing of late arrivals in CE...
Posted by chermenin <gi...@git.apache.org>.
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2396
@mushketyk Could you rebase this PR, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2396: [FLINK-4395][cep] Eager processing of late arrivals in CE...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2396
Hi @kl0u,
Sure. I'll rebase it today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2396: [FLINK-4395][cep] Eager processing of late arrivals in CE...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2396
Thanks a lot @mushketyk !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2396: [FLINK-4395][cep] Eager processing of late arrivals in CE...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2396
Hi @mushketyk,
Could you rebase this on the master so that I can have a look?
Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2396: [FLINK-4395][cep] Eager processing of late arrivals in CE...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2396
Hi @mushketyk could you close this PR? I also commented on the related JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2396: [FLINK-4395][cep] Eager processing of late arrival...
Posted by chermenin <gi...@git.apache.org>.
Github user chermenin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2396#discussion_r97272232
--- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/ProcessingType.java ---
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.cep.operator;
+
+/**
+ * Defines what time should be considered when even is being processed.
+ */
+public enum ProcessingType {
+ // Consider time of event occurance when processing an event
+ EVENT_TIME,
+ processingType, // Consider local system time when processing an event
--- End diff --
I think this value is unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2396: [FLINK-4395][cep] Eager processing of late arrivals in CE...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2396
Closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2396: [FLINK-4395][cep] Eager processing of late arrivals in CE...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2396
Thank you for looking into this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---