You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/12/29 18:51:31 UTC

[kudu-CR] [fs] fix NO ROCKSDB build

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22276


Change subject: [fs] fix NO_ROCKSDB build
......................................................................

[fs] fix NO_ROCKSDB build

This is a follow-up to 50eaddfa9448c188008939a4b8c1439e9d4c95d6.

Change-Id: I62e8390b0775c471825aa022acec7f77d391a3a8
---
M src/kudu/fs/fs_manager-test.cc
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/22276/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I62e8390b0775c471825aa022acec7f77d391a3a8
Gerrit-Change-Number: 22276
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [fs] fix NO ROCKSDB build

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22276 )

Change subject: [fs] fix NO_ROCKSDB build
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/879/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62e8390b0775c471825aa022acec7f77d391a3a8
Gerrit-Change-Number: 22276
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 29 Dec 2024 20:19:29 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] fix NO ROCKSDB build

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22276 )

Change subject: [fs] fix NO_ROCKSDB build
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62e8390b0775c471825aa022acec7f77d391a3a8
Gerrit-Change-Number: 22276
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 30 Dec 2024 02:39:28 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] fix NO ROCKSDB build

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22276 )

Change subject: [fs] fix NO_ROCKSDB build
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/879/


-- 
To view, visit http://gerrit.cloudera.org:8080/22276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62e8390b0775c471825aa022acec7f77d391a3a8
Gerrit-Change-Number: 22276
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 29 Dec 2024 18:51:39 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] fix NO ROCKSDB build

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [fs] fix NO_ROCKSDB build
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I62e8390b0775c471825aa022acec7f77d391a3a8
Gerrit-Change-Number: 22276
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] [fs] fix NO ROCKSDB build

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22276 )

Change subject: [fs] fix NO_ROCKSDB build
......................................................................

[fs] fix NO_ROCKSDB build

This is a follow-up to 50eaddfa9448c188008939a4b8c1439e9d4c95d6.

Change-Id: I62e8390b0775c471825aa022acec7f77d391a3a8
Reviewed-on: http://gerrit.cloudera.org:8080/22276
Reviewed-by: Yifan Zhang <ch...@163.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/fs/fs_manager-test.cc
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Yifan Zhang: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I62e8390b0775c471825aa022acec7f77d391a3a8
Gerrit-Change-Number: 22276
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] [fs] fix NO ROCKSDB build

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22276 )

Change subject: [fs] fix NO_ROCKSDB build
......................................................................


Patch Set 1: Verified+1

unrelated build failures of known flaky tests:
  * RELEASE
  * TSAN


-- 
To view, visit http://gerrit.cloudera.org:8080/22276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62e8390b0775c471825aa022acec7f77d391a3a8
Gerrit-Change-Number: 22276
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 30 Dec 2024 03:42:26 +0000
Gerrit-HasComments: No