[GitHub] [accumulo] ctubbsii commented on issue #729: Metrics not instance specific for multiple tablet-servers in 1.9

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #729: Metrics not instance specific for multiple tablet-servers in 1.9
URL: https://github.com/apache/accumulo/issues/729#issuecomment-476365274
 
 
   I'm not sure this is a bug. The `accumulo.service.instance` being set in the script is associated with the default configuration for file-based logging. It's not for the metrics. The system property for metrics appears to be a similar property, but we do not try to set it for the user. The user can set this system property in their `accumulo-env.sh` script on startup, though, when they set up metrics for their system.
   
   We could converge on the same property... but there's already a lot of assumptions being made when setting these for our scripts, that I'd be concerned that this would break somebody who managed to rely on those assumptions. In 2.0, it is my intent to argue in favor of moving more of these things under the user's control, and to have fewer assumptions in our own scripts and/or configuration about the user's intended setup. The scripts in 2.0 have already been rewritten with this principle in mind, so I'm not sure there's a lot of value in messing with the 1.9 scripts.
   
   I'm closing this and #730 for now, but if setting this property for metrics in one's `accumulo-env.sh` script is insufficient, we can revisit this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services