You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/05/04 15:33:40 UTC
[GitHub] satansk commented on issue #1738: [Dubbo-1691] Add unit tests for
MulticastRegister #1691
satansk commented on issue #1738: [Dubbo-1691] Add unit tests for MulticastRegister #1691
URL: https://github.com/apache/incubator-dubbo/pull/1738#issuecomment-386638830
There's still one thing to mention, there are some typos in `MulticastRegister` which I did not correct this time:
```Java
private final InetAddress mutilcastAddress;
private final MulticastSocket mutilcastSocket;
private final int mutilcastPort;
```
The reason that I did not correct them is they have some public method related to names, if modified, the public interface will be damaged.
So what can we do here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org