You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Mike Edwards (JIRA)" <de...@tuscany.apache.org> on 2010/10/29 12:10:19 UTC
[jira] Created: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
-----------------------------------------------------------------------------------------------------------------------------------
Key: TUSCANY-3760
URL: https://issues.apache.org/jira/browse/TUSCANY-3760
Project: Tuscany
Issue Type: Bug
Components: Java SCA Misc Implementation Extensions
Affects Versions: Java-SCA-2.0-M5
Reporter: Mike Edwards
Assignee: Mike Edwards
Fix For: Java-SCA-2.x
Stripes:
a) MANIFEST contains these entries:
javax.servlet.jsp,
javax.servlet.jsp.tagext,
...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
b) POM problems:
Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
b) Implementation-Web-Runtime:
Dependencies:
javax.servlet.servlet-api
org.apache.geronimo.specs.geronimo-jsp_2.1_spec
org.apache.geronimo.specs.geronimo-el_1.0_spec
...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (TUSCANY-3760) Stripes and Implementation-Web-Runtime
modules have POM & MANIFEST errors that causes execution failures with main
build under OSGi
Posted by ant elder <an...@gmail.com>.
Mike, I'm -1 on doing that, that isn't a fix as it then breaks using
implementation.web and requires users to add explicit excludes. I'm
out today but will add something to get you going by tomorrow.
...ant
On Mon, Nov 22, 2010 at 10:21 AM, Mike Edwards (JIRA)
<de...@tuscany.apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934433#action_12934433 ]
>
> Mike Edwards commented on TUSCANY-3760:
> ---------------------------------------
>
> Well, I've no problem with the idea of replacing my original fix with something that is better - but I DO have a problem with leaving the trunk in a state that's broken. I'm going to put back my original fix - at least this enables things to work.
>
> If you want to work on something that's better - fine, go ahead, but please don't leave trunk broken.
>
>> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
>> -----------------------------------------------------------------------------------------------------------------------------------
>>
>> Key: TUSCANY-3760
>> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
>> Project: Tuscany
>> Issue Type: Bug
>> Components: Java SCA Misc Implementation Extensions
>> Affects Versions: Java-SCA-2.0-M5
>> Reporter: Mike Edwards
>> Fix For: Java-SCA-2.x
>>
>>
>> Stripes:
>> a) MANIFEST contains these entries:
>> javax.servlet.jsp,
>> javax.servlet.jsp.tagext,
>> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
>> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
>> b) POM problems:
>> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
>> b) Implementation-Web-Runtime:
>> Dependencies:
>> javax.servlet.servlet-api
>> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
>> org.apache.geronimo.specs.geronimo-el_1.0_spec
>> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "Mike Edwards (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934433#action_12934433 ]
Mike Edwards commented on TUSCANY-3760:
---------------------------------------
Well, I've no problem with the idea of replacing my original fix with something that is better - but I DO have a problem with leaving the trunk in a state that's broken. I'm going to put back my original fix - at least this enables things to work.
If you want to work on something that's better - fine, go ahead, but please don't leave trunk broken.
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "ant elder (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ant elder reopened TUSCANY-3760:
--------------------------------
Assignee: (was: Mike Edwards)
I'm reopening this as I don't think this is the correct fix. The dependencies intentionally use a scope or provided because those dependencies are provided by the environment not by transitive dependencies on the Tuscany module. Things like the servlet-api should not be a compile dependency because that means now everywhere the Tuscany module is used it also needs to have an exclude on the servlet-api otherwise it will conflict with the one provided in the runtime environment. This is exactly the same as with the Tuscany host-webapp module which also uses provided scope.
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "Raymond Feng (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933904#action_12933904 ]
Raymond Feng commented on TUSCANY-3760:
---------------------------------------
I see the same problem here.
IMO, we should have servlet and jsp jars in the distribution (for example, to run embedded Jetty) or PDE target platform. We should instruct users when they deploy Tuscany into a web container, these jars should be excluded as they are provided by the Web container.
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: Usage of "provided" scope, Re: [jira] Commented: (TUSCANY-3760)
Posted by Luciano Resende <lu...@gmail.com>.
On Wed, Nov 24, 2010 at 1:12 AM, Mike Edwards
<mi...@gmail.com> wrote:
>
> Folks,
>
> I agree with these observations that Raymond makes.
>
> It seems problematic to mark things in the build as "provided" given that
> there is a range of target runtimes - if there one or more of those target
> runtimes which does not provide the relevant dependencies. And that does
> seem to be the case at the moment.
>
> I agree with Raymond that it seems more logical to perform the work of
> including or excluding specific dependency JARs at the point that the
> relevant distributions are produced, since at that point, it is possible to
> describe the characteristics of that runtime.
>
> A problem I see with the point that we've reached now is that the
> distribution/all does not "do what it says on the tin" - in that it is NOT
> the complete set of Tuscany dependencies any longer, but some subset.
>
>
> Yours, Mike.
>
+1
--
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: Usage of "provided" scope, Re: [jira] Commented: (TUSCANY-3760)
Posted by Mike Edwards <mi...@gmail.com>.
On 23/11/2010 17:52, Raymond Feng wrote:
> I'm sorry to see a VETO here while the technical discussion is still active.
>
> Anyway, going back to the technical side, here is the description from the maven doc about the
> "provided" scope:
>
> *provided*
> This is much like compile, but indicates you expect the JDK or a container to provide the dependency
> at runtime. For example, when building a web application for the Java Enterprise Edition, you would
> set the dependency on the Servlet API and related Java EE APIs to scope provided because the web
> container provides those classes. This scope is only available on the compilation and test
> classpath, and is not transitive.
>
> The key is that we assume the hosting environment will provide the jar if we use "provided" scope.
> In fact, Tuscany supports quite a few hosting environment out of the box and it can be embedded into
> other environment. Let me list a few:
>
> * Standalone launcher
> * Use Node API with the application
> * Eclipse plugin
> * Eclipse IDE with PDE
> * OSGi runtime
> * Webapp
> * Google App Engine
> * Tomcat deep integration
>
> Do we have all the hosting environment that provide the servlet/jsp jars? Maybe some of us only care
> about a subset of the options, but we need to understand if the dependency is really provided?
>
> IMO, we probably need to deal with these exclusions at maven assembly level when the distributions
> (for example, the WAR) are produced.
>
> Thanks,
> Raymond
Folks,
I agree with these observations that Raymond makes.
It seems problematic to mark things in the build as "provided" given that there is a range of target
runtimes - if there one or more of those target runtimes which does not provide the relevant
dependencies. And that does seem to be the case at the moment.
I agree with Raymond that it seems more logical to perform the work of including or excluding
specific dependency JARs at the point that the relevant distributions are produced, since at that
point, it is possible to describe the characteristics of that runtime.
A problem I see with the point that we've reached now is that the distribution/all does not "do what
it says on the tin" - in that it is NOT the complete set of Tuscany dependencies any longer, but
some subset.
Yours, Mike.
Usage of "provided" scope, Re: [jira] Commented: (TUSCANY-3760)
Posted by Raymond Feng <cy...@gmail.com>.
I'm sorry to see a VETO here while the technical discussion is still active.
Anyway, going back to the technical side, here is the description from the maven doc about the "provided" scope:
provided
This is much like compile, but indicates you expect the JDK or a container to provide the dependency at runtime. For example, when building a web application for the Java Enterprise Edition, you would set the dependency on the Servlet API and related Java EE APIs to scope provided because the web container provides those classes. This scope is only available on the compilation and test classpath, and is not transitive.
The key is that we assume the hosting environment will provide the jar if we use "provided" scope. In fact, Tuscany supports quite a few hosting environment out of the box and it can be embedded into other environment. Let me list a few:
* Standalone launcher
* Use Node API with the application
* Eclipse plugin
* Eclipse IDE with PDE
* OSGi runtime
* Webapp
* Google App Engine
* Tomcat deep integration
Do we have all the hosting environment that provide the servlet/jsp jars? Maybe some of us only care about a subset of the options, but we need to understand if the dependency is really provided?
IMO, we probably need to deal with these exclusions at maven assembly level when the distributions (for example, the WAR) are produced.
Thanks,
Raymond
________________________________________________________________
Raymond Feng
rfeng@apache.org
Apache Tuscany PMC member and committer: tuscany.apache.org
Co-author of Tuscany SCA In Action book: www.tuscanyinaction.com
Personal Web Site: www.enjoyjava.com
________________________________________________________________
On Nov 23, 2010, at 5:06 AM, ant elder (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934823#action_12934823 ]
>
> ant elder commented on TUSCANY-3760:
> ------------------------------------
>
> Also see ML http://apache.markmail.org/message/dwemu7p72hi6elku
>
> In case it wasn't clear from the previous comment that -1 was a VETO, I've reverted that change now. I have updated features/eclipse-pde to include those dependencies now which should fix the problem so can you try using that please? If you still have issues please work with me on or off list to resolve them.
>
>> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
>> -----------------------------------------------------------------------------------------------------------------------------------
>>
>> Key: TUSCANY-3760
>> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
>> Project: Tuscany
>> Issue Type: Bug
>> Components: Java SCA Misc Implementation Extensions
>> Affects Versions: Java-SCA-2.0-M5
>> Reporter: Mike Edwards
>> Fix For: Java-SCA-2.x
>>
>>
>> Stripes:
>> a) MANIFEST contains these entries:
>> javax.servlet.jsp,
>> javax.servlet.jsp.tagext,
>> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
>> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
>> b) POM problems:
>> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
>> b) Implementation-Web-Runtime:
>> Dependencies:
>> javax.servlet.servlet-api
>> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
>> org.apache.geronimo.specs.geronimo-el_1.0_spec
>> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "ant elder (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934823#action_12934823 ]
ant elder commented on TUSCANY-3760:
------------------------------------
Also see ML http://apache.markmail.org/message/dwemu7p72hi6elku
In case it wasn't clear from the previous comment that -1 was a VETO, I've reverted that change now. I have updated features/eclipse-pde to include those dependencies now which should fix the problem so can you try using that please? If you still have issues please work with me on or off list to resolve them.
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "Mike Edwards (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933892#action_12933892 ]
Mike Edwards commented on TUSCANY-3760:
---------------------------------------
Ant,
Your fix does not work. With the current trunk build, I end up with same problem with Implementation-Web-Runtime that was listed in the original JIRA - so that the PDE environment is simply missing javax.servle.jsp and javax.servlet..jsp.tagext
How do you expect these dependencies to get into the PDE environment?
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "Raymond Feng (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933922#action_12933922 ]
Raymond Feng commented on TUSCANY-3760:
---------------------------------------
It's not just for PDE development time. I have two use cases at runtime:
1) Start a standalone Tuscany runtime with embedded Jetty to provide HTTP communication. Servlet jars are required.
2) Start an OSGi runtime to run Tuscany with OSGi, it needs to resolve bundle dependencies on the Servlet/JSP APIs.
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "ant elder (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932852#action_12932852 ]
ant elder commented on TUSCANY-3760:
------------------------------------
That simply is not the case. The standalone environment doesn't support implementation.web or JSPs. Implementation.web doesn't work in the standalone environment as it is for webapps, which applies to both the WAR distribution and the webapp runtime, neither of which should be having transitive dependencies on APIs which are already part of the environment.
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "ant elder (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931347#action_12931347 ]
ant elder commented on TUSCANY-3760:
------------------------------------
If you get the Tuscany source code, either from SVN or a src distribution and try to develop that in the Eclipse PDE you need to first tell Eclipse about the PDE target. Currently that PDE target is generated and included in the binary distribution. That means if the binary distribution does not include all of the code or dependencies used by all the src then the target does not work and Eclipse reports errors.
It is quite legitimate for the binary distribution to not include everything thats in the src tree, it might be in the unreleased folder, not yet ready for release, released somewhere else (like the Tomcat war distribution) or there may be a provided scope dependency as is being reported in this JIRA.
So to decouple the PDE target generation from the distribution means that the distribution does not have to be exactly the same as what is required by PDE to develop all the Tuscany source code in the Eclipse PDE.
This doesn't need to change the binary distribution at all from what we have today, though it would then seem unnecessary to keep the PDE target thats included in the binary distribution so we'd probably want to stop doing that.
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "Mike Edwards (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Edwards resolved TUSCANY-3760.
-----------------------------------
Resolution: Fixed
1) Stripes
MANIFEST.MF:
Remove the entries:
javax.servlet.jsp,
javax.servlet.jsp.tagext,
POM.XML
Change the scope of the stripes dependency to "compile" which ensures that the dependency gets into the main distribution build:
<dependency>
<groupId>net.sourceforge.stripes</groupId>
<artifactId>stripes</artifactId>
<version>1.5.2</version>
<scope>compile</scope>
</dependency>
2) Implementation-Web-Runtime
POM.XML
Change the 3 dependencies to "compile" scope:
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>servlet-api</artifactId>
<version>2.5</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.geronimo.specs</groupId>
<artifactId>geronimo-jsp_2.1_spec</artifactId>
<version>1.0.1</version>
<scope>compile</scope>
</dependency>
<!-- provided scope doesn't pull in transitive dependencies -->
<dependency>
<groupId>org.apache.geronimo.specs</groupId>
<artifactId>geronimo-el_1.0_spec</artifactId>
<version>1.0.1</version>
<scope>compile</scope>
</dependency>
Committed in 1028665 & 1028666
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Assignee: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "ant elder (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930979#action_12930979 ]
ant elder commented on TUSCANY-3760:
------------------------------------
A way to fix this properly would be to decouple the PDE target generation from the Tuscany distribution. The PDE target needs to be generated using all the dependencies that are needed for the modules being developed in PDE, thats a different set of dependencies than what might be included in the distribution, and, we shouldn't have the contents of the distribution restricted to what is required by the PDE environment.
I'll have a go at doing this, but i would like in the meantime to put back the implementation-web dependencies to use provided scope to fix that problem. (they have been provided scope for yonks so has something happened to make this a PDE issue now?)
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "Raymond Feng (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932552#action_12932552 ]
Raymond Feng commented on TUSCANY-3760:
---------------------------------------
The Tuscany binary distribution is for the standalone deployment. Therefore, the servlet/jsp API jars should be included (i.e., using compile scope instead of provided). These jars should only be excluded for the WAR distribution, and we can use the assembly plugin to exclude them instead.
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "ant elder (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932018#action_12932018 ]
ant elder commented on TUSCANY-3760:
------------------------------------
I've now added features/eclipse-pde to the eclipse build profile so mvn -Peclipse will now build the PDE target in the features/eclipse-pde/target
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "Luciano Resende (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931100#action_12931100 ]
Luciano Resende commented on TUSCANY-3760:
------------------------------------------
Could you elaborate more on what do you mean to "decouple the PDE target generation from the Tuscany distribution" .
Would this then cause a duplication of all dependencies ?
Would you still produce a OSGified distribution where we can just point a OSGi runtime to it ?
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-3760) Stripes and
Implementation-Web-Runtime modules have POM & MANIFEST errors that causes
execution failures with main build under OSGi
Posted by "ant elder (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933914#action_12933914 ]
ant elder commented on TUSCANY-3760:
------------------------------------
Thats because I stopped fixing it as it didn't sound like there was consensus on what to do.
IMHO it doesn't seem correct to put things in the binary distribution which aren't used by anything in the binary distribution (eg JSPs are only supported in webapps not standalone), and, it also doesn't really seem right to have the PDE target in the binary distribution either because the PDE target is used for developing the source code so you need the source and are never going to be using it with only the binary distribution.
It seems wrong to me to have webapp only things like implementation.web have compile dependencies on the things that are known to be provided by the webapp container and quite un-user friendly to say it would be ok as users can add an exclude.
So i think it would be better to separate out the PDE target generation from the binary distribution into something like features/pde-target. Then if you get the source form either an SVN checkout or from a release source distribution and you want to use the PDE you do a build with the pde profile and point eclipse at the target that builds. That makes it much clearer whats going on in my view than saying you first have to build the all distribution.
I'm happy to finish making these changes but i wont if people aren't happy with that approach.
> Stripes and Implementation-Web-Runtime modules have POM & MANIFEST errors that causes execution failures with main build under OSGi
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3760
> URL: https://issues.apache.org/jira/browse/TUSCANY-3760
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Misc Implementation Extensions
> Affects Versions: Java-SCA-2.0-M5
> Reporter: Mike Edwards
> Fix For: Java-SCA-2.x
>
>
> Stripes:
> a) MANIFEST contains these entries:
> javax.servlet.jsp,
> javax.servlet.jsp.tagext,
> ...these are not actually supplied in any dependency of Stripes, but they are also not used by Stripes either.
> Earlier versions of the servlet-api package used to contain these packages, but not the most recent ones, which thus causes a resolution failure under OSGi, even though the code will actually execute successfully.
> b) POM problems:
> Dependency net.sourceforge.stripes.stripes is declared as "provided" but does not appear in the main build at all, leading to an OSGI resolution failure.
> b) Implementation-Web-Runtime:
> Dependencies:
> javax.servlet.servlet-api
> org.apache.geronimo.specs.geronimo-jsp_2.1_spec
> org.apache.geronimo.specs.geronimo-el_1.0_spec
> ...are declared as "provided" scope, but don't turn up in the main distribution build, leading to a resolution failure for this module under OSGi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.