[GitHub] [arrow] zagto commented on a diff in pull request #13330: ARROW-16772: [C++] Implement encode and decode functions for Run-Length encoding

[GitBox <gi...@apache.org>]

zagto commented on code in PR #13330:
URL: https://github.com/apache/arrow/pull/13330#discussion_r891554578


##########
cpp/src/arrow/compute/api_vector.cc:
##########
@@ -163,6 +163,8 @@ static auto kRankOptionsType = GetFunctionOptionsType<RankOptions>(
     DataMember("sort_keys", &RankOptions::sort_keys),
     DataMember("null_placement", &RankOptions::null_placement),
     DataMember("tiebreaker", &RankOptions::tiebreaker));
+static auto kRunLengthEncodeOptionsType =
+    GetFunctionOptionsType<RunLengthEncodeOptions>();

Review Comment:
   These options options currently unnecessary. To me that seems to be the place where we could specify the run length values type, if we decide to support multiple ones



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org