[GitHub] [maven] gnodet commented on a change in pull request #436: [MNG-7080] Add a --color option to simplify color support

[GitBox <gi...@apache.org>]

gnodet commented on a change in pull request #436:
URL: https://github.com/apache/maven/pull/436#discussion_r626529239



##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
##########
@@ -149,6 +151,7 @@ public CLIManager()
         options.addOption( Option.builder( LEGACY_LOCAL_REPOSITORY ).longOpt( "legacy-local-repository" ).desc( "Use Maven 2 Legacy Local Repository behaviour, ie no use of _remote.repositories. Can also be activated by using -Dmaven.legacyLocalRepo=true" ).build() );
         options.addOption( Option.builder( BUILDER ).longOpt( "builder" ).hasArg().desc( "The id of the build strategy to use" ).build() );
         options.addOption( Option.builder( NO_TRANSFER_PROGRESS ).longOpt( "no-transfer-progress" ).desc( "Do not display transfer progress when downloading or uploading" ).build() );
+        options.addOption( Option.builder().longOpt( COLOR ).hasArg().desc( "Color support mode (auto/always/never)" ).build() );

Review comment:
       I agree with @michael-o , the goal of this PR is to make things easier for users, rather than looking for a non trivial `-Dstyle.color=always` option, so the `--color` option similar to the gnu `ls` or ` grep` seems a better choice to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org