You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Leif Hedstrom <zw...@apache.org> on 2011/08/29 04:02:39 UTC
ink_* -> ats_* in the "core" code
Hi all,
I'd like to propose that we start using ats_ as a prefix for new APIs
(and rewrites etc.) in the internal code. Long term, we probably should
migrate existing ink_ prefixes to ats_, and perhaps also consider using
C++ name spaces. My rationale for using "ats" instead "ts" in the
internal (core) code is to make it easily distinguishable from the
public APIs (which are all prefix e.g. TS or ts). This is very useful
when grepping through the code IMO.
Cheers,
-- Leif
Re: ink_* -> ats_* in the "core" code
Posted by John Plevyak <jp...@gmail.com>.
I am just grumbling ;). ats_ is the way to go. ink is just confusing after
all these years.
On Sep 2, 2011 6:13 PM, "Leif Hedstrom" <zw...@apache.org> wrote:
> On Sep 2, 2011, at 6:56 PM, John Plevyak <jp...@acm.org> wrote:
>
>> Sorry to chime in on this so late.
>>
>> If the APIs were not already TSXXX I would have preferred to make the
>> external ones ats_
>> and the internal ts_, but now that we are already down the path I agree
with
>> Leif that we should
>> change all the internal apis to ats_.
>
> I'd have to check, but I think we voted on this :)
>>
>> The downside is that* ink_ *can be done fast with the right hand while
ats_
>> uses both
>> the left pinky for the 'a' and then for the _ (for me) which makes typing
it
>> slower :)
>
>
> Maybe it should be asd_? Or qwe_ ? What else would be easy? I'm ok with
ink_ too, I don't think it matters a big deal, and we can honor the origins
of the code :).
>
> Leif
>
>>
>> john
>>
>> On Mon, Aug 29, 2011 at 5:36 AM, Leif Hedstrom <zw...@apache.org> wrote:
>>
>>> On Aug 29, 2011, at 5:03 AM, Igor Galić <i....@brainsware.org> wrote:
>>>
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> Hi all,
>>>>>
>>>>> I'd like to propose that we start using ats_ as a prefix for new APIs
>>>>> (and rewrites etc.) in the internal code. Long term, we probably
>>>>
>>>> Can you please break down for us what exactly internal code is.
>>>
>>> Anything that is not external / public API.
>>>
>>>>
>>>>> should
>>>>> migrate existing ink_ prefixes to ats_, and perhaps also consider
>>>>> using
>>>>> C++ name spaces. My rationale for using "ats" instead "ts" in the
>>>>
>>>> So this is - in the long term, going to be more than a
>>>>
>>>> sed -i 's/\bink_/ats_/g' **/*.cc **/*.[ch]
>>>
>>> Maybe. The prefix ink just doesn't make sense in Apache.
>>>
>>>>
>>>>> internal (core) code is to make it easily distinguishable from the
>>>>> public APIs (which are all prefix e.g. TS or ts). This is very useful
>>>>> when grepping through the code IMO.
>>>>
>>>> Just have to teach people *how* to grep ;)
>>>>
>>>> igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] % ack-grep
>>> '\bink_' | wc -l
>>>> 8333
>>>> igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] % ack-grep
>>> 'ink_' | wc -l
>>>> 8540
>>>> igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] %
>>>
>>>
>>> Ya, but if we change ink to ts, this would now find both public APIs and
>>> code, and the core code. The message was not really about whether we
should
>>> keep ink or not, I think that's a given, it's whether it should be ts or
>>> ats. And I'd prefer ats myself.
>>>
>>> -- Leif
>>>
>>>>
>>>>> Cheers,
>>>>>
>>>>> -- Leif
>>>>
>>>>
>>>> So long,
>>>>
>>>> i
>>>>
>>>> --
>>>> Igor Galić
>>>>
>>>> Tel: +43 (0) 664 886 22 883
>>>> Mail: i.galic@brainsware.org
>>>> URL: http://brainsware.org/
>>>> GPG: 571B 8B8A FC97 266D BDA3 EF6F 43AD 80A4 5779 3257
>>>
Re: ink_* -> ats_* in the "core" code
Posted by Leif Hedstrom <zw...@apache.org>.
On Sep 2, 2011, at 6:56 PM, John Plevyak <jp...@acm.org> wrote:
> Sorry to chime in on this so late.
>
> If the APIs were not already TSXXX I would have preferred to make the
> external ones ats_
> and the internal ts_, but now that we are already down the path I agree with
> Leif that we should
> change all the internal apis to ats_.
I'd have to check, but I think we voted on this :)
>
> The downside is that* ink_ *can be done fast with the right hand while ats_
> uses both
> the left pinky for the 'a' and then for the _ (for me) which makes typing it
> slower :)
Maybe it should be asd_? Or qwe_ ? What else would be easy? I'm ok with ink_ too, I don't think it matters a big deal, and we can honor the origins of the code :).
Leif
>
> john
>
> On Mon, Aug 29, 2011 at 5:36 AM, Leif Hedstrom <zw...@apache.org> wrote:
>
>> On Aug 29, 2011, at 5:03 AM, Igor Galić <i....@brainsware.org> wrote:
>>
>>>
>>>
>>> ----- Original Message -----
>>>> Hi all,
>>>>
>>>> I'd like to propose that we start using ats_ as a prefix for new APIs
>>>> (and rewrites etc.) in the internal code. Long term, we probably
>>>
>>> Can you please break down for us what exactly internal code is.
>>
>> Anything that is not external / public API.
>>
>>>
>>>> should
>>>> migrate existing ink_ prefixes to ats_, and perhaps also consider
>>>> using
>>>> C++ name spaces. My rationale for using "ats" instead "ts" in the
>>>
>>> So this is - in the long term, going to be more than a
>>>
>>> sed -i 's/\bink_/ats_/g' **/*.cc **/*.[ch]
>>
>> Maybe. The prefix ink just doesn't make sense in Apache.
>>
>>>
>>>> internal (core) code is to make it easily distinguishable from the
>>>> public APIs (which are all prefix e.g. TS or ts). This is very useful
>>>> when grepping through the code IMO.
>>>
>>> Just have to teach people *how* to grep ;)
>>>
>>> igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] % ack-grep
>> '\bink_' | wc -l
>>> 8333
>>> igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] % ack-grep
>> 'ink_' | wc -l
>>> 8540
>>> igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] %
>>
>>
>> Ya, but if we change ink to ts, this would now find both public APIs and
>> code, and the core code. The message was not really about whether we should
>> keep ink or not, I think that's a given, it's whether it should be ts or
>> ats. And I'd prefer ats myself.
>>
>> -- Leif
>>
>>>
>>>> Cheers,
>>>>
>>>> -- Leif
>>>
>>>
>>> So long,
>>>
>>> i
>>>
>>> --
>>> Igor Galić
>>>
>>> Tel: +43 (0) 664 886 22 883
>>> Mail: i.galic@brainsware.org
>>> URL: http://brainsware.org/
>>> GPG: 571B 8B8A FC97 266D BDA3 EF6F 43AD 80A4 5779 3257
>>
Re: ink_* -> ats_* in the "core" code
Posted by John Plevyak <jp...@acm.org>.
Sorry to chime in on this so late.
If the APIs were not already TSXXX I would have preferred to make the
external ones ats_
and the internal ts_, but now that we are already down the path I agree with
Leif that we should
change all the internal apis to ats_.
The downside is that* ink_ *can be done fast with the right hand while ats_
uses both
the left pinky for the 'a' and then for the _ (for me) which makes typing it
slower :)
john
On Mon, Aug 29, 2011 at 5:36 AM, Leif Hedstrom <zw...@apache.org> wrote:
> On Aug 29, 2011, at 5:03 AM, Igor Galić <i....@brainsware.org> wrote:
>
> >
> >
> > ----- Original Message -----
> >> Hi all,
> >>
> >> I'd like to propose that we start using ats_ as a prefix for new APIs
> >> (and rewrites etc.) in the internal code. Long term, we probably
> >
> > Can you please break down for us what exactly internal code is.
>
> Anything that is not external / public API.
>
> >
> >> should
> >> migrate existing ink_ prefixes to ats_, and perhaps also consider
> >> using
> >> C++ name spaces. My rationale for using "ats" instead "ts" in the
> >
> > So this is - in the long term, going to be more than a
> >
> > sed -i 's/\bink_/ats_/g' **/*.cc **/*.[ch]
>
> Maybe. The prefix ink just doesn't make sense in Apache.
>
> >
> >> internal (core) code is to make it easily distinguishable from the
> >> public APIs (which are all prefix e.g. TS or ts). This is very useful
> >> when grepping through the code IMO.
> >
> > Just have to teach people *how* to grep ;)
> >
> > igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] % ack-grep
> '\bink_' | wc -l
> > 8333
> > igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] % ack-grep
> 'ink_' | wc -l
> > 8540
> > igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] %
>
>
> Ya, but if we change ink to ts, this would now find both public APIs and
> code, and the core code. The message was not really about whether we should
> keep ink or not, I think that's a given, it's whether it should be ts or
> ats. And I'd prefer ats myself.
>
> -- Leif
>
> >
> >> Cheers,
> >>
> >> -- Leif
> >
> >
> > So long,
> >
> > i
> >
> > --
> > Igor Galić
> >
> > Tel: +43 (0) 664 886 22 883
> > Mail: i.galic@brainsware.org
> > URL: http://brainsware.org/
> > GPG: 571B 8B8A FC97 266D BDA3 EF6F 43AD 80A4 5779 3257
>
Re: ink_* -> ats_* in the "core" code
Posted by Leif Hedstrom <zw...@apache.org>.
On Aug 29, 2011, at 5:03 AM, Igor Galić <i....@brainsware.org> wrote:
>
>
> ----- Original Message -----
>> Hi all,
>>
>> I'd like to propose that we start using ats_ as a prefix for new APIs
>> (and rewrites etc.) in the internal code. Long term, we probably
>
> Can you please break down for us what exactly internal code is.
Anything that is not external / public API.
>
>> should
>> migrate existing ink_ prefixes to ats_, and perhaps also consider
>> using
>> C++ name spaces. My rationale for using "ats" instead "ts" in the
>
> So this is - in the long term, going to be more than a
>
> sed -i 's/\bink_/ats_/g' **/*.cc **/*.[ch]
Maybe. The prefix ink just doesn't make sense in Apache.
>
>> internal (core) code is to make it easily distinguishable from the
>> public APIs (which are all prefix e.g. TS or ts). This is very useful
>> when grepping through the code IMO.
>
> Just have to teach people *how* to grep ;)
>
> igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] % ack-grep '\bink_' | wc -l
> 8333
> igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] % ack-grep 'ink_' | wc -l
> 8540
> igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] %
Ya, but if we change ink to ts, this would now find both public APIs and code, and the core code. The message was not really about whether we should keep ink or not, I think that's a given, it's whether it should be ts or ats. And I'd prefer ats myself.
-- Leif
>
>> Cheers,
>>
>> -- Leif
>
>
> So long,
>
> i
>
> --
> Igor Galić
>
> Tel: +43 (0) 664 886 22 883
> Mail: i.galic@brainsware.org
> URL: http://brainsware.org/
> GPG: 571B 8B8A FC97 266D BDA3 EF6F 43AD 80A4 5779 3257
Re: ink_* -> ats_* in the "core" code
Posted by Igor Galić <i....@brainsware.org>.
----- Original Message -----
> Hi all,
>
> I'd like to propose that we start using ats_ as a prefix for new APIs
> (and rewrites etc.) in the internal code. Long term, we probably
Can you please break down for us what exactly internal code is.
> should
> migrate existing ink_ prefixes to ats_, and perhaps also consider
> using
> C++ name spaces. My rationale for using "ats" instead "ts" in the
So this is - in the long term, going to be more than a
sed -i 's/\bink_/ats_/g' **/*.cc **/*.[ch]
> internal (core) code is to make it easily distinguishable from the
> public APIs (which are all prefix e.g. TS or ts). This is very useful
> when grepping through the code IMO.
Just have to teach people *how* to grep ;)
igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] % ack-grep '\bink_' | wc -l
8333
igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] % ack-grep 'ink_' | wc -l
8540
igalic@tynix ~/src/asf/trafficserver (svn)-[trunk:1162727] %
> Cheers,
>
> -- Leif
So long,
i
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 571B 8B8A FC97 266D BDA3 EF6F 43AD 80A4 5779 3257