You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by mzbyszynski <gi...@git.apache.org> on 2016/07/21 22:28:31 UTC
[GitHub] storm pull request #1584: STORM-1992 Added artifacts to make storm.js into a...
GitHub user mzbyszynski opened a pull request:
https://github.com/apache/storm/pull/1584
STORM-1992 Added artifacts to make storm.js into an npm package
Posting for feedback! Please let me know if I am on the right track. This PR relates to [STORM-1992](https://issues.apache.org/jira/browse/STORM-1992)
```bash
$ mvn deploy -P npmjs
```
Would publish the package to npmjs.com as **storm-multilang-js** (I could not think of a better name that was not taken) along with the other deployments the build performs. It would have be manually executed right now because you need to have run `npm login` before hand to enter your credentials. I have not found a clean way to make this automated, but if that is a requirement I can probably get it working in an unclean way.
I published the package with a bogus version number here as an example: https://www.npmjs.com/package/storm-multilang-js
I added a `stormjs` utility to make it easier to call a js spout or bolt from a topology by taking care of some of the boilerplate. I also cleaned up `storm.js` a little bit by adding missing semi-colons and making string quotation consistent.
I'm unsure about the README.md file for the npm package. Should I add more to it or should it just point to documentation living somewhere else?
Thank you!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mzbyszynski/storm STORM-1992_multilang_js_npm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1584.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1584
----
commit afe5e3e4db519ea5877c6e9a7c5b2da668784814
Author: Marc Zbyszynski <mz...@xlhybrids.com>
Date: 2016-07-21T21:55:57Z
STORM-1992 Added artifacts to multilang-javascript to package it as an npm module, and added npmjs profile for deploying the package to npmjs.con
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1584: STORM-1992 Added artifacts to make storm.js into a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1584
---
[GitHub] storm issue #1584: STORM-1992 Added artifacts to make storm.js into an npm p...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1584
My apologies for letting this go without review for so long.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---