You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Chesnay Schepler (Jira)" <ji...@apache.org> on 2023/02/07 09:23:00 UTC

[jira] [Commented] (FLINK-30833) TestMetricGroup supports being closed

    [ https://issues.apache.org/jira/browse/FLINK-30833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685169#comment-17685169 ] 

Chesnay Schepler commented on FLINK-30833:
------------------------------------------

Do you even need to test the closing? Wouldn't the metric being registered again suffice?

> TestMetricGroup supports being closed
> -------------------------------------
>
>                 Key: FLINK-30833
>                 URL: https://issues.apache.org/jira/browse/FLINK-30833
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Metrics, Tests
>    Affects Versions: 1.16.1
>            Reporter: Mason Chen
>            Priority: Major
>
> For testing purposes, closing a metric group is required to verify logic that maintains metrics. The TestMetricGroup needs to extend AbstractMetricGroup<> to support this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)