You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by mx...@apache.org on 2019/01/22 15:18:26 UTC

[beam] branch master updated: [BEAM-6473] Disable failing new test on Flink runner.

This is an automated email from the ASF dual-hosted git repository.

mxm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 5fd56a4  [BEAM-6473] Disable failing new test on Flink runner.
     new c75d0fd  Merge pull request #7581: [BEAM-6473] Disable failing new test on Flink runner
5fd56a4 is described below

commit 5fd56a46ae3eefa27873fba42888f66ebf733448
Author: Robert Bradshaw <ro...@google.com>
AuthorDate: Mon Jan 21 12:27:18 2019 +0100

    [BEAM-6473] Disable failing new test on Flink runner.
---
 .../apache_beam/runners/portability/flink_runner_test.py      |  4 ++++
 .../apache_beam/runners/portability/fn_api_runner_test.py     | 11 ++++++-----
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/sdks/python/apache_beam/runners/portability/flink_runner_test.py b/sdks/python/apache_beam/runners/portability/flink_runner_test.py
index cc267f2..500ef8e 100644
--- a/sdks/python/apache_beam/runners/portability/flink_runner_test.py
+++ b/sdks/python/apache_beam/runners/portability/flink_runner_test.py
@@ -162,6 +162,10 @@ if __name__ == '__main__':
     def test_error_traceback_includes_user_code(self):
       raise unittest.SkipTest("BEAM-6019")
 
+    def test_flattened_side_input(self):
+      # BEAM-6473
+      super(FlinkRunnerTest, self).test_flattened_side_input(extended=False)
+
     def test_metrics(self):
       """Run a simple DoFn that increments a counter, and verify that its
        expected value is written to a temporary file by the FileReporter"""
diff --git a/sdks/python/apache_beam/runners/portability/fn_api_runner_test.py b/sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
index f649b82..5515646 100644
--- a/sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
+++ b/sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
@@ -188,7 +188,7 @@ class FnApiRunnerTest(unittest.TestCase):
               (9, list(range(7, 10)))]),
           label='windowed')
 
-  def test_flattened_side_input(self):
+  def test_flattened_side_input(self, extended=True):
     with self.create_pipeline() as p:
       main = p | 'main' >> beam.Create([None])
       side1 = p | 'side1' >> beam.Create([('a', 1)])
@@ -199,10 +199,11 @@ class FnApiRunnerTest(unittest.TestCase):
           main | beam.Map(lambda a, b: (a, b), beam.pvalue.AsDict(side)),
           equal_to([(None, {'a': 1, 'b': 2})]),
           label='CheckFlattenAsSideInput')
-      assert_that(
-          (side, side3) | 'FlattenAfter' >> beam.Flatten(),
-          equal_to([('a', 1), ('b', 2), ('another type')]),
-          label='CheckFlattenOfSideInput')
+      if extended:
+        assert_that(
+            (side, side3) | 'FlattenAfter' >> beam.Flatten(),
+            equal_to([('a', 1), ('b', 2), ('another type')]),
+            label='CheckFlattenOfSideInput')
 
   def test_gbk_side_input(self):
     with self.create_pipeline() as p: