You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/09 09:58:09 UTC

[GitHub] [pulsar] leizhiyuan commented on pull request #16996: [fix][broker] Fix memory leak if entry exists in cache

leizhiyuan commented on PR #16996:
URL: https://github.com/apache/pulsar/pull/16996#issuecomment-1209170401

   > > @lhotari it seems we can continue on this patch since it includes #17007?
   > 
   > @tisonkun yes that makes sense. I guess the description of this PR could be improved to mention that this reverts invalid OpAddEntry changes made by #12258 .
   > 
   > @leizhiyuan please update the description's motivation and modifications to simply state this.
   > 
   > Motivation: PR #12258 made changes to OpAddEntry which causes a memory leak when the entry is already in the cache. Modifications: Revert PR #12258 changes to OpAddEntry
   > 
   > To be honest, I hate all the extra text that the issue template has been adding to issue descriptions since that makes it hard to read issues when there's just generated text in the descriptions... @tisonkun I wonder if that is addressed with your recent changes to issue templates? (#16902)
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org