You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@usergrid.apache.org by senthilkumar-kj <gi...@git.apache.org> on 2015/04/21 23:11:01 UTC

[GitHub] incubator-usergrid pull request: fix rest compilation failures

GitHub user senthilkumar-kj opened a pull request:

    https://github.com/apache/incubator-usergrid/pull/235

    fix rest compilation failures

    Fixed compilation failures in rest module. Added index methods to EntityManagerFactory to impl later.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/senthilkumar-kj/incubator-usergrid rest_compilation_failures

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-usergrid/pull/235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #235
    
----
commit 4c2777185ffffbff891556f2378a72e8bb0c8222
Author: Senthil Kumar K <se...@gmail.com>
Date:   2015-04-21T21:08:41Z

    fix rest compilation failures

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: fix rest compilation failures

Posted by senthilkumar-kj <gi...@git.apache.org>.

Github user senthilkumar-kj commented on a diff in the pull request:

    https://github.com/apache/incubator-usergrid/pull/235#discussion_r28844641
  
    --- Diff: stack/core/src/main/java/org/apache/usergrid/persistence/EntityManagerFactory.java ---
    @@ -189,6 +188,12 @@ public UUID initializeApplication(
     
         public Health getIndexHealth();
     
    +    void rebuildAllIndexes(ProgressObserver progressObserver);
    --- End diff --
    
    hi @tnine, I still see the line here - https://github.com/apache/incubator-usergrid/blob/two-dot-o-dev/stack/rest/src/main/java/org/apache/usergrid/rest/IndexResource.java#L88
    I'll pull and push again 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: fix rest compilation failures

Posted by tnine <gi...@git.apache.org>.

Github user tnine commented on a diff in the pull request:

    https://github.com/apache/incubator-usergrid/pull/235#discussion_r28843632
  
    --- Diff: stack/core/src/main/java/org/apache/usergrid/persistence/EntityManagerFactory.java ---
    @@ -189,6 +188,12 @@ public UUID initializeApplication(
     
         public Health getIndexHealth();
     
    +    void rebuildAllIndexes(ProgressObserver progressObserver);
    --- End diff --
    
    I could be wrong, but I thought I already removed these today in the 2.0-dev branch. Can you pull and re-merge?  I'm going to reference the indexService directly in our rest tier, rather than continue to funnel data through the emf interfaces.  Eventually we'll have more events in the refactored system.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: fix rest compilation failures

Posted by GERey <gi...@git.apache.org>.

Github user GERey commented on the pull request:

    https://github.com/apache/incubator-usergrid/pull/235#issuecomment-130467070
  
    Hi! These changes were addressed and compilation issues are fixed. If you don't mind could you close or update the pr. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---