You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Mike Drob (JIRA)" <ji...@apache.org> on 2014/07/10 23:23:04 UTC

[jira] [Created] (ACCUMULO-2987) Verify that all shell scripts read role files consistently

Mike Drob created ACCUMULO-2987:
-----------------------------------

             Summary: Verify that all shell scripts read role files consistently
                 Key: ACCUMULO-2987
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2987
             Project: Accumulo
          Issue Type: Bug
          Components: scripts
            Reporter: Mike Drob


We rely on role files to determine proper behaviour in several of our scripts. However, we are inconsistent in how we parse these files, sometimes using cat, other times grep to drop blank lines and yet other times dropping lines that begin with {{#}}.

Also, as noted in the review for ACCUMULO-2423, shellcheck warns that:

{quote}
for f in $(grep -v '^#' "$ACCUMULO_CONF_DIR/masters")
         ^-- SC2013: To read lines rather than words, pipe/redirect to a 'while read' loop.
{quote}

We should verify correctness of all of these invocations.



--
This message was sent by Atlassian JIRA
(v6.2#6252)