You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/08/11 17:33:58 UTC
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2505: FINERACT-1670: Rework command source to store dates in UTC
adamsaghy commented on code in PR #2505:
URL: https://github.com/apache/fineract/pull/2505#discussion_r943746986
##########
fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandSource.java:
##########
@@ -72,16 +71,24 @@ public class CommandSource extends AbstractPersistableCustom {
@JoinColumn(name = "maker_id", nullable = false)
private AppUser maker;
- @Column(name = "made_on_date", nullable = false)
- private LocalDateTime madeOnDate;
+ /*
+ * Deprecated: Columns and data left untouched to help migration.
+ *
+ * @Column(name = "made_on_date", nullable = false) private LocalDateTime madeOnDate;
+ *
+ * @Column(name = "checked_on_date", nullable = true) private LocalDateTime checkedOnDate;
+ */
+
+ @Column(name = "made_on_utc", nullable = false)
Review Comment:
You have eagle eyes. I was wondering change the native query instead. I started this kind of naming convention with all the new fields i have added, like: created_on_utc,
created_by,...
Would you mind if i stick to the column name but would change in the native query the alias?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org