You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2024/01/08 15:06:54 UTC
Re: [PR] GH-39064: [C++][Parquet] Support row group filtering for nested paths for struct fields [arrow]
jorisvandenbossche commented on code in PR #39065:
URL: https://github.com/apache/arrow/pull/39065#discussion_r1444797018
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -897,16 +907,25 @@ Result<std::vector<compute::Expression>> ParquetFileFragment::TestRowGroups(
ARROW_ASSIGN_OR_RAISE(auto match, ref.FindOneOrNone(*physical_schema_));
if (match.empty()) continue;
- if (statistics_expressions_complete_[match[0]]) continue;
- statistics_expressions_complete_[match[0]] = true;
+ const SchemaField* schema_field = &manifest_->schema_fields[match[0]];
Review Comment:
I would like to merge this before the 15.0 branch cut-off, so going to merge as is, but will look into factoring it out as a helper function in a follow-up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org