[GitHub] [arrow-datafusion] izveigor commented on a diff in pull request #7313: feat: `array-empty`

["izveigor (via GitHub)" <gi...@apache.org>]

izveigor commented on code in PR #7313:
URL: https://github.com/apache/arrow-datafusion/pull/7313#discussion_r1297404263


##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -2363,6 +2363,16 @@ from flatten_table;
 [1, 2, 3] [1, 2, 3, 4, 5, 6] [1, 2, 3] [1.0, 2.1, 2.2, 3.2, 3.3, 3.4]
 [1, 2, 3, 4, 5, 6] [8] [1, 2, 3] [1.0, 2.0, 3.0, 4.0, 5.0, 6.0]
 
+query I

Review Comment:
   You should add some comments (like `empty scalar function #1`).



##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -2363,6 +2363,16 @@ from flatten_table;
 [1, 2, 3] [1, 2, 3, 4, 5, 6] [1, 2, 3] [1.0, 2.1, 2.2, 3.2, 3.3, 3.4]
 [1, 2, 3, 4, 5, 6] [8] [1, 2, 3] [1.0, 2.0, 3.0, 4.0, 5.0, 6.0]
 
+query I

Review Comment:
   You should add some comments (like `#empty scalar function #1`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org