You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "emkornfield (via GitHub)" <gi...@apache.org> on 2026/02/24 21:22:59 UTC

[PR] GH-49385: Clarify empty schema contract on stream_reader [arrow]

emkornfield opened a new pull request, #49386:
URL: https://github.com/apache/arrow/pull/49386

   ### Rationale for this change
   
   StreamReader inherently does not support empty schemas. Guard this case with an exception.
   
   ### What changes are included in this PR?
   
   Added validation around the parquet reader passed in.
   
   ### Are these changes tested?
   
   Yes added unit tests.
   
   ### Are there any user-facing changes?
   
   A change that might be debatable is the constructor for this class can now throw, but it was never marked noexcept.
   
   **This PR contains a "Critical Fix".** 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-49385: Clarify empty schema contract on stream_reader [arrow]

Posted by "emkornfield (via GitHub)" <gi...@apache.org>.

emkornfield merged PR #49386:
URL: https://github.com/apache/arrow/pull/49386


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-49385: Clarify empty schema contract on stream_reader [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.

pitrou commented on PR #49386:
URL: https://github.com/apache/arrow/pull/49386#issuecomment-3989516256

   Perhaps rebase to try and fix CI (not sure that'll be sufficient though)? Apart from that, feel free to merge, and thanks for tackling this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-49385: Clarify empty schema contract on stream_reader [arrow]

Posted by "emkornfield (via GitHub)" <gi...@apache.org>.

emkornfield commented on PR #49386:
URL: https://github.com/apache/arrow/pull/49386#issuecomment-3999571578

   > Perhaps rebase to try and fix CI (not sure that'll be sufficient though)? Apart from that, feel free to merge, and thanks for tackling this!
   
   Unfortunately still seeing unrelated errors (i.e. for flight)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-49385: Clarify empty schema contract on stream_reader [arrow]

Posted by "emkornfield (via GitHub)" <gi...@apache.org>.

emkornfield commented on PR #49386:
URL: https://github.com/apache/arrow/pull/49386#issuecomment-3955402600

   CI failures seem related to build infra?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-49385: [C++][Parquet] Clarify empty schema contract on stream_reader [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.

conbench-apache-arrow[bot] commented on PR #49386:
URL: https://github.com/apache/arrow/pull/49386#issuecomment-4001655089

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit fcf9dd6aa50731c2b7d83e495ecbc04b002968d6.
   
   There was 1 benchmark result indicating a performance regression:
   
   - Commit Run on `amd64-m5-4xlarge-linux` at [2026-03-04 20:47:23Z](https://conbench.arrow-dev.org/compare/runs/04bf12cb04d7421ca89cf9cd5047c2f6...1b245e4b616a40538bfbdbadc328b1aa/)
     - [`file-write` (Python) with compression=lz4, dataset=fanniemae_2016Q4, file_type=feather, input_type=table](https://conbench.arrow-dev.org/compare/benchmarks/069a87b3b79b72be8000a3c66d303c89...069a8ac73acb7f03800050f82bc725e5)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/65812318838) has more details. It also includes information about 41 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org