[GitHub] opennlp pull request #229: OPENNLP-1091 Findbugs issues and IDE warnings

[kinow <gi...@git.apache.org>]

GitHub user kinow opened a pull request:

    https://github.com/apache/opennlp/pull/229

    OPENNLP-1091 Findbugs issues and IDE warnings

    Thank you for contributing to Apache OpenNLP.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
        - Not yet, intentionally, in case we decide to trim some of the changes
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kinow/opennlp findbugs-issues

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #229
    
----
commit 6b815cee11b8297933ae1ddf37c071cb3a92984e
Author: Bruno P. Kinoshita <br...@yahoo.com.br>
Date:   2017-06-09T13:28:29Z

    Fixing few issues found in FindBugs

commit fee514d290ab718c1406675168e595a76809db2c
Author: Bruno P. Kinoshita <br...@yahoo.com.br>
Date:   2017-06-09T22:18:16Z

    Fix warnings found with IDE

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] opennlp pull request #229: OPENNLP-1091: Findbugs issues and IDE warnings

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/opennlp/pull/229


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---