You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by te...@apache.org on 2014/03/04 18:44:30 UTC
svn commit: r1574149 - in
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver:
StoreFile.java TimeRangeTracker.java
Author: tedyu
Date: Tue Mar 4 17:44:30 2014
New Revision: 1574149
URL: http://svn.apache.org/r1574149
Log:
HBASE-10624 Fix 2 new findbugs warnings introduced by HBASE-10598
Modified:
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java?rev=1574149&r1=1574148&r2=1574149&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java Tue Mar 4 17:44:30 2014
@@ -635,7 +635,7 @@ public class StoreFile {
public Long getMinimumTimestamp() {
return (getReader().timeRangeTracker == null) ?
null :
- getReader().timeRangeTracker.minimumTimestamp;
+ getReader().timeRangeTracker.getMinimumTimestamp();
}
/**
@@ -1505,7 +1505,7 @@ public class StoreFile {
}
public long getMaxTimestamp() {
- return timeRangeTracker == null ? Long.MAX_VALUE : timeRangeTracker.maximumTimestamp;
+ return timeRangeTracker == null ? Long.MAX_VALUE : timeRangeTracker.getMaximumTimestamp();
}
}
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java?rev=1574149&r1=1574148&r2=1574149&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java Tue Mar 4 17:44:30 2014
@@ -134,18 +134,18 @@ public class TimeRangeTracker implements
return maximumTimestamp;
}
- public void write(final DataOutput out) throws IOException {
+ public synchronized void write(final DataOutput out) throws IOException {
out.writeLong(minimumTimestamp);
out.writeLong(maximumTimestamp);
}
- public void readFields(final DataInput in) throws IOException {
+ public synchronized void readFields(final DataInput in) throws IOException {
this.minimumTimestamp = in.readLong();
this.maximumTimestamp = in.readLong();
}
@Override
- public String toString() {
+ public synchronized String toString() {
return "[" + minimumTimestamp + "," + maximumTimestamp + "]";
}
}