You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/02/19 21:01:17 UTC
[DISCUSS] Merging of feature/GEODE-917 - renaming artifacts to geode-
I'd like to merge in the changes for GEODE-917. This will rename all of the
subdirectories to be geode-XXX instead of gemfire-XXX.
It will also change the maven artifacts to be geode-XXX once this change is
merged.
Any objections? A review of all of the diffs is a bit annoying, but I
attached a diff to the ticket that shows the changes other than the renames:
https://issues.apache.org/jira/secure/attachment/12788739/GEODE-917.diff
-Dan
Re: [DISCUSS] Merging of feature/GEODE-917 - renaming artifacts to geode-
Posted by William Markito <wm...@pivotal.io>.
Thanks Dan! Small typo there: gradle clean.
In summary:
1 - Do "gradle clean" before pulling develop (git pull) after projects
being renamed
OR
2 - Do a rm -rf gemfire-* after you pick up these changes to remove project
folders left.
Really happy to see the new structure btw:
Root project 'geode'
+--- Project ':extensions/geode-modules'
+--- Project ':extensions/geode-modules-assembly'
+--- Project ':extensions/geode-modules-hibernate'
+--- Project ':extensions/geode-modules-session'
+--- Project ':extensions/geode-modules-tomcat7'
+--- Project ':geode-assembly'
+--- Project ':geode-common'
+--- Project ':geode-core'
+--- Project ':geode-cq'
+--- Project ':geode-joptsimple'
+--- Project ':geode-json'
+--- Project ':geode-junit'
+--- Project ':geode-lucene'
+--- Project ':geode-pulse'
+--- Project ':geode-rebalancer'
+--- Project ':geode-wan'
+--- Project ':geode-web'
\--- Project ':geode-web-api'
On Mon, Feb 22, 2016 at 11:18 AM, Dan Smith <ds...@pivotal.io> wrote:
> William pointed out that this will require some work on your part to clean
> up your workspace when you pick up these changes.
>
> Git will not automatically remove the gemfire- directories if you have
> build artifacts in them. So you can either do a git clean before you pull,
> or just rm -rf gemfire-* after you pick up these changes.
>
> You will probably need to regenerate your eclipse/intellij project files
> and reimport the projects as well, because now all of the projects are
> named geode-.
>
> -Dan
>
> On Mon, Feb 22, 2016 at 10:41 AM, Dan Smith <ds...@pivotal.io> wrote:
>
> > Ok. I have checked in this merge.
> >
> > The subprojects are now named geode-. This affects the directory names in
> > your checkout, as well as the names of the maven artifacts. Additionally,
> > gemfire-core-dependencies.jar is now called geode-dependencies.jar.
> >
> > See GEODE-917 for additional details.
> >
> > -Dan
> >
> > On Fri, Feb 19, 2016 at 1:51 PM, Nitin Lamba <ni...@ampool.io> wrote:
> >
> >> +1
> >>
> >> Agree with Anthony - all the artifacts in the /lib directory still read
> >> 'gemfire-XXX.jar'. If renaming is simple enough, it should be picked-up
> as
> >> part of this change.
> >>
> >> Nitin
> >>
> >> ________________________________________
> >> From: Anthony Baker <ab...@pivotal.io>
> >> Sent: Friday, February 19, 2016 1:43 PM
> >> To: dev@geode.incubator.apache.org
> >> Subject: Re: [DISCUSS] Merging of feature/GEODE-917 - renaming artifacts
> >> to geode-
> >>
> >> Thanks for testing this out Dan! Downstream project integrations will
> >> need to update maven artifact ID’s.
> >>
> >> Another part of this changeset is renaming
> >> ‘gemfire-core-dependencies.jar’ to ‘geode-dependencies.jar’.
> >>
> >>
> >> +1
> >>
> >> Anthony
> >>
> >> > On Feb 19, 2016, at 12:01 PM, Dan Smith <ds...@pivotal.io> wrote:
> >> >
> >> > I'd like to merge in the changes for GEODE-917. This will rename all
> of
> >> the
> >> > subdirectories to be geode-XXX instead of gemfire-XXX.
> >> >
> >> > It will also change the maven artifacts to be geode-XXX once this
> >> change is
> >> > merged.
> >> >
> >> > Any objections? A review of all of the diffs is a bit annoying, but I
> >> > attached a diff to the ticket that shows the changes other than the
> >> renames:
> >> >
> >> >
> >>
> https://issues.apache.org/jira/secure/attachment/12788739/GEODE-917.diff
> >> >
> >> > -Dan
> >>
> >>
> >
>
--
~/William
Re: [DISCUSS] Merging of feature/GEODE-917 - renaming artifacts to geode-
Posted by Dan Smith <ds...@pivotal.io>.
William pointed out that this will require some work on your part to clean
up your workspace when you pick up these changes.
Git will not automatically remove the gemfire- directories if you have
build artifacts in them. So you can either do a git clean before you pull,
or just rm -rf gemfire-* after you pick up these changes.
You will probably need to regenerate your eclipse/intellij project files
and reimport the projects as well, because now all of the projects are
named geode-.
-Dan
On Mon, Feb 22, 2016 at 10:41 AM, Dan Smith <ds...@pivotal.io> wrote:
> Ok. I have checked in this merge.
>
> The subprojects are now named geode-. This affects the directory names in
> your checkout, as well as the names of the maven artifacts. Additionally,
> gemfire-core-dependencies.jar is now called geode-dependencies.jar.
>
> See GEODE-917 for additional details.
>
> -Dan
>
> On Fri, Feb 19, 2016 at 1:51 PM, Nitin Lamba <ni...@ampool.io> wrote:
>
>> +1
>>
>> Agree with Anthony - all the artifacts in the /lib directory still read
>> 'gemfire-XXX.jar'. If renaming is simple enough, it should be picked-up as
>> part of this change.
>>
>> Nitin
>>
>> ________________________________________
>> From: Anthony Baker <ab...@pivotal.io>
>> Sent: Friday, February 19, 2016 1:43 PM
>> To: dev@geode.incubator.apache.org
>> Subject: Re: [DISCUSS] Merging of feature/GEODE-917 - renaming artifacts
>> to geode-
>>
>> Thanks for testing this out Dan! Downstream project integrations will
>> need to update maven artifact ID’s.
>>
>> Another part of this changeset is renaming
>> ‘gemfire-core-dependencies.jar’ to ‘geode-dependencies.jar’.
>>
>>
>> +1
>>
>> Anthony
>>
>> > On Feb 19, 2016, at 12:01 PM, Dan Smith <ds...@pivotal.io> wrote:
>> >
>> > I'd like to merge in the changes for GEODE-917. This will rename all of
>> the
>> > subdirectories to be geode-XXX instead of gemfire-XXX.
>> >
>> > It will also change the maven artifacts to be geode-XXX once this
>> change is
>> > merged.
>> >
>> > Any objections? A review of all of the diffs is a bit annoying, but I
>> > attached a diff to the ticket that shows the changes other than the
>> renames:
>> >
>> >
>> https://issues.apache.org/jira/secure/attachment/12788739/GEODE-917.diff
>> >
>> > -Dan
>>
>>
>
Re: [DISCUSS] Merging of feature/GEODE-917 - renaming artifacts to geode-
Posted by Dan Smith <ds...@pivotal.io>.
Ok. I have checked in this merge.
The subprojects are now named geode-. This affects the directory names in
your checkout, as well as the names of the maven artifacts. Additionally,
gemfire-core-dependencies.jar is now called geode-dependencies.jar.
See GEODE-917 for additional details.
-Dan
On Fri, Feb 19, 2016 at 1:51 PM, Nitin Lamba <ni...@ampool.io> wrote:
> +1
>
> Agree with Anthony - all the artifacts in the /lib directory still read
> 'gemfire-XXX.jar'. If renaming is simple enough, it should be picked-up as
> part of this change.
>
> Nitin
>
> ________________________________________
> From: Anthony Baker <ab...@pivotal.io>
> Sent: Friday, February 19, 2016 1:43 PM
> To: dev@geode.incubator.apache.org
> Subject: Re: [DISCUSS] Merging of feature/GEODE-917 - renaming artifacts
> to geode-
>
> Thanks for testing this out Dan! Downstream project integrations will
> need to update maven artifact ID’s.
>
> Another part of this changeset is renaming ‘gemfire-core-dependencies.jar’
> to ‘geode-dependencies.jar’.
>
>
> +1
>
> Anthony
>
> > On Feb 19, 2016, at 12:01 PM, Dan Smith <ds...@pivotal.io> wrote:
> >
> > I'd like to merge in the changes for GEODE-917. This will rename all of
> the
> > subdirectories to be geode-XXX instead of gemfire-XXX.
> >
> > It will also change the maven artifacts to be geode-XXX once this change
> is
> > merged.
> >
> > Any objections? A review of all of the diffs is a bit annoying, but I
> > attached a diff to the ticket that shows the changes other than the
> renames:
> >
> > https://issues.apache.org/jira/secure/attachment/12788739/GEODE-917.diff
> >
> > -Dan
>
>
Re: [DISCUSS] Merging of feature/GEODE-917 - renaming artifacts to
geode-
Posted by Nitin Lamba <ni...@ampool.io>.
+1
Agree with Anthony - all the artifacts in the /lib directory still read 'gemfire-XXX.jar'. If renaming is simple enough, it should be picked-up as part of this change.
Nitin
________________________________________
From: Anthony Baker <ab...@pivotal.io>
Sent: Friday, February 19, 2016 1:43 PM
To: dev@geode.incubator.apache.org
Subject: Re: [DISCUSS] Merging of feature/GEODE-917 - renaming artifacts to geode-
Thanks for testing this out Dan! Downstream project integrations will need to update maven artifact ID’s.
Another part of this changeset is renaming ‘gemfire-core-dependencies.jar’ to ‘geode-dependencies.jar’.
+1
Anthony
> On Feb 19, 2016, at 12:01 PM, Dan Smith <ds...@pivotal.io> wrote:
>
> I'd like to merge in the changes for GEODE-917. This will rename all of the
> subdirectories to be geode-XXX instead of gemfire-XXX.
>
> It will also change the maven artifacts to be geode-XXX once this change is
> merged.
>
> Any objections? A review of all of the diffs is a bit annoying, but I
> attached a diff to the ticket that shows the changes other than the renames:
>
> https://issues.apache.org/jira/secure/attachment/12788739/GEODE-917.diff
>
> -Dan
Re: [DISCUSS] Merging of feature/GEODE-917 - renaming artifacts to geode-
Posted by Anthony Baker <ab...@pivotal.io>.
Thanks for testing this out Dan! Downstream project integrations will need to update maven artifact ID’s.
Another part of this changeset is renaming ‘gemfire-core-dependencies.jar’ to ‘geode-dependencies.jar’.
+1
Anthony
> On Feb 19, 2016, at 12:01 PM, Dan Smith <ds...@pivotal.io> wrote:
>
> I'd like to merge in the changes for GEODE-917. This will rename all of the
> subdirectories to be geode-XXX instead of gemfire-XXX.
>
> It will also change the maven artifacts to be geode-XXX once this change is
> merged.
>
> Any objections? A review of all of the diffs is a bit annoying, but I
> attached a diff to the ticket that shows the changes other than the renames:
>
> https://issues.apache.org/jira/secure/attachment/12788739/GEODE-917.diff
>
> -Dan