You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/28 03:25:44 UTC

[GitHub] [pulsar] gaoran10 commented on a change in pull request #11116: [Ledger] Fix ledger rollover scheduled task

gaoran10 commented on a change in pull request #11116:
URL: https://github.com/apache/pulsar/pull/11116#discussion_r659454565



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -3929,4 +3918,13 @@ public void clearBacklogFailed(ManagedLedgerException exception, Object ctx) {
             return CompletableFuture.completedFuture(ensembles);
         });
     }
+
+    private void updateLastLedgerCreatedTime() {

Review comment:
       This method is used to update `lastLedgerCreatedTimestamp`, updating this field indicates that the ledger has been created succesully, and at this time, we could add a scheduled task to check the ledger reaches maximum rollover time or not.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org