You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "unbridled-41 (via GitHub)" <gi...@apache.org> on 2026/10/09 21:39:54 UTC
[PR] fix(alert): answer a rule update with the stored rule, not with the request [rocketmq-dashboard]
unbridled-41 opened a new pull request, #5989:
URL: https://github.com/apache/rocketmq-dashboard/pull/5989
### Which Issue(s) This PR Fixes
Fixes #5988
### Problem / Evidence
`AlertService.updateRule` returned the request-derived VO while `lastTriggered` is not an editable field the repository preserves (`MybatisPlusAlertRepository`: "lastTriggered is not an editable field ... keeps the skip-on-null behaviour"), and the page adopts the response as the row:
```
AlertServiceTest: updateRuleShouldReturnTheStoredRuleInsteadOfTheRequestTest
expected: "2026-10-01T10:00:00" but was: null
```
`toggleRule` already answers with the stored row, so the same table disagreed with itself.
### Root cause / Fix
The update path has no read-back. Return `alertRepository.findRuleById(id)`, falling back to the request when the row cannot be read.
### Priority and scoring
**PRIORITY 52** - impact 18/40 (a wrong value in a management table after every edit), blast radius 12/20 (both domains), reproducibility 18/20 (pinned by the new test), maintenance value 4/20. **FIX_CONFIDENCE 88**.
### Tests
`cd server && mvn -o -B -ntp test -Dtest='AlertRuleControllerTest,AlertServiceTest'` -> `Tests run: 106, Failures: 0, Errors: 0`; the new case fails before the change and passes after it; `checkstyle:check` passes.
### Risk
One extra read per update; the response now reflects the stored row (the intended contract).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): answer a rule update with the stored rule, not with the request [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #5989:
URL: https://github.com/apache/rocketmq-dashboard/pull/5989#issuecomment-6090232036
### CI status of this PR
`Backend Tests (Java 21)` — see the note below the list.
The four remaining red jobs are red for every branch, including `rocketmq-studio` itself:
- `Backend Build (Java 21)` — the `binary-license-gate` antrun step fails on a list of third-party jars (`spring-ai-*`, `swagger-ui`, `tencentcloud-sdk-*`, `zstd-jni`, ... : "missing complete upstream LICENSE/COPYING; a POM name or link is not a substitute"). This PR touches no build configuration; tracked by #5341.
- `Frontend Build (Node 20)` / `Frontend Docker Build` — the frontend licence manifest check fails the same way on branches that do not touch `web/` at all; tracked by #5346.
- `rmqctl Build (Go)` — `cmd` `TestMessageQueryCompletenessWarningTest` yaml subtests: `got {"items":[{"size":"3",...}]}, want {"size":3,...}`, i.e. the YAML renderer writes numbers as quoted strings where the test expects integer literals. Reproduced locally with `cd rmqctl && go test ./cmd/` from a checkout whose `rmqctl/` tree is byte-identical to `rocketmq-studio`'s, and owned by open PR #5850 ("keep yaml numbers unquoted").
`Backend Tests (Java 21)` failure attribution: `ResourceOwnershipGuardTest.migrationConcurrentStartupIsIdempotentTest` — `org.h2.jdbc.JdbcSQLNonTransientException: General error: java.util.ConcurrentModificationException` — the known flaky H2 concurrency test tracked by #5302. It reproduces independently of this diff (which touches no persistence code) and the same job passes on sibling PRs of the same batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): answer a rule update with the stored rule, not with the request [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5989: fix(alert): answer a rule update with the stored rule, not with the request
URL: https://github.com/apache/rocketmq-dashboard/pull/5989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): answer a rule update with the stored rule, not with the request [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #5989:
URL: https://github.com/apache/rocketmq-dashboard/pull/5989#issuecomment-6091426773
### Verification on the final commit (branch + commit + command results)
Every command from the description re-run on a fresh worktree of this branch (`git worktree add <dir> fork/<branch>`, no local modifications), at commit `87d8737f98`:
| command | exit | result |
| --- | --- | --- |
| `cd server && mvn -o -B -ntp test -Dtest='AlertRuleControllerTest,AlertServiceTest'` | 0 | `Tests run: 106, Failures: 0, Errors: 0, Skipped: 0 · BUILD SUCCESS` |
CI note: on this repository the `Backend Build` (binary-license-gate), `Frontend Build` / `Frontend Docker Build` (licence manifest) and `rmqctl Build` (YAML renderer quoting) jobs are red for every branch, trunk included; the module-level commands above are unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): answer a rule update with the stored rule, not with the request [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5989:
URL: https://github.com/apache/rocketmq-dashboard/pull/5989#issuecomment-6227216587
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org