You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/12/15 06:01:06 UTC
[PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
cloud-fan opened a new pull request, #44364:
URL: https://github.com/apache/spark/pull/44364
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Uses can set up their own HMS and let Spark connects to it. We have no control over it and somtimes it's not even Hive but just a HMS-API-compatible service.
Spark should be more fault-tolerant when calling HMS APIs. This PR fixes an issue in `hive.getTable` with `throwException = false`, to make sure we don't throw error when can't fetch the table.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
avoid query failure caused by HMS bugs.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
in our product environment
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1857326100
@yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1427622193
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##########
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
tableName: String,
throwException: Boolean): Table = {
recordHiveCall()
- val table = hive.getTable(dbName, tableName, throwException)
+ val table = try {
+ hive.getTable(dbName, tableName, throwException)
+ } catch {
+ // Hive may have bugs and still throw an exception even if `throwException` is false.
+ case e: HiveException if !throwException && e.getMessage.contains("Unable to fetch table") =>
Review Comment:
Is it ok to skip 2nd condition as throwException=false means the caller side requires suppressing expressions？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1857683044
Thanks. Merged to master 3.5 and 3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1462870595
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##########
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
tableName: String,
throwException: Boolean): Table = {
recordHiveCall()
- val table = hive.getTable(dbName, tableName, throwException)
+ val table = try {
+ hive.getTable(dbName, tableName, throwException)
+ } catch {
+ // Hive may have bugs and still throw an exception even if `throwException` is false.
+ case e: HiveException if !throwException =>
Review Comment:
hmm, so `tableExists` fails as well if there is permission issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1857521039
@yaooqinn which null value were you referencing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1462773777
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##########
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
tableName: String,
throwException: Boolean): Table = {
recordHiveCall()
- val table = hive.getTable(dbName, tableName, throwException)
+ val table = try {
+ hive.getTable(dbName, tableName, throwException)
+ } catch {
+ // Hive may have bugs and still throw an exception even if `throwException` is false.
+ case e: HiveException if !throwException =>
Review Comment:
another idea: shall we check `tableExists` and only throw exception if table does exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1905667118
It's Ok to be reverted simply by [2aed25b](https://github.com/apache/spark/commit/2aed25b15dbac44dd43caceb908b77f998a0634d) [20da7c0](https://github.com/apache/spark/commit/20da7c0f3c44b1b435171058da36d8cd59391ba8) and [c158a7a](https://github.com/apache/spark/commit/c158a7a0b9fd9ac9af6f467040c56d8a7ce258cd) from 4.0.0/3.5.1/3.4.3 as none of them is released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1462905132
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##########
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
tableName: String,
throwException: Boolean): Table = {
recordHiveCall()
- val table = hive.getTable(dbName, tableName, throwException)
+ val table = try {
+ hive.getTable(dbName, tableName, throwException)
+ } catch {
+ // Hive may have bugs and still throw an exception even if `throwException` is false.
+ case e: HiveException if !throwException =>
Review Comment:
Yes. Actually, if we intend to check only tableExists or not, we can revert this and restore the hive's behavior. Hive only suppresses table not found ex while throwException=true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1905358925
Shall I add back `e.getMessage.contains("Unable to fetch table")`? This is verified on production that AWS Glue may throw such exceptions while `throwException` is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1427725075
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##########
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
tableName: String,
throwException: Boolean): Table = {
recordHiveCall()
- val table = hive.getTable(dbName, tableName, throwException)
+ val table = try {
+ hive.getTable(dbName, tableName, throwException)
+ } catch {
+ // Hive may have bugs and still throw an exception even if `throwException` is false.
+ case e: HiveException if !throwException && e.getMessage.contains("Unable to fetch table") =>
Review Comment:
```suggestion
case e: HiveException if !throwException =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1905394773
For HMS, A pre-step of `getMSC()` wrapped together might also throw ex before the meta API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #44364: [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false
URL: https://github.com/apache/spark/pull/44364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1857541417
NVM, I was wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1857512068
It looks like we do not handle `null` values at the caller side, this PR increases NPE risks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1462973783
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##########
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
tableName: String,
throwException: Boolean): Table = {
recordHiveCall()
- val table = hive.getTable(dbName, tableName, throwException)
+ val table = try {
+ hive.getTable(dbName, tableName, throwException)
+ } catch {
+ // Hive may have bugs and still throw an exception even if `throwException` is false.
+ case e: HiveException if !throwException =>
Review Comment:
OK let's revert it then. Can you help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1905342167
As #44831 reported, we should revert this first. Hive getTable is an RPC call, it could result in various client-server issues that the client shall be aware of? WDYT @cloud-fan ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46417][SQL] Do not fail when calling hive.getTable and throwException is false [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1462800905
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##########
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
tableName: String,
throwException: Boolean): Table = {
recordHiveCall()
- val table = hive.getTable(dbName, tableName, throwException)
+ val table = try {
+ hive.getTable(dbName, tableName, throwException)
+ } catch {
+ // Hive may have bugs and still throw an exception even if `throwException` is false.
+ case e: HiveException if !throwException =>
Review Comment:
`tableExists` seems to depend on getTable(xx).nonEmpty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org