You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/14 01:13:31 UTC
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #345: Customizable ingressClassName for gateway
tokers commented on code in PR #345:
URL: https://github.com/apache/apisix-helm-chart/pull/345#discussion_r970206913
##########
charts/apisix/templates/ingress.yaml:
##########
@@ -34,6 +34,9 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
+ {{- if .Values.gateway.ingress.className }}
+ ingressClassName: {{ .Values.gateway.ingress.className }}
Review Comment:
This field was introduced since k8s 1.18, but the ingress resource for apisix is also compatible with older ingress version (extensions). So only add this field only if the k8s version is new enough.
We also need to consider removing the support for older ingress versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org