You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "shirenchuang (via GitHub)" <gi...@apache.org> on 2023/08/25 10:55:21 UTC
[GitHub] [rocketmq] shirenchuang opened a new pull request, #7258: Enhancement getNamesrvAddr trim #7252
shirenchuang opened a new pull request, #7258:
URL: https://github.com/apache/rocketmq/pull/7258
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7252
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] shirenchuang commented on a diff in pull request #7258: Enhancement getNamesrvAddr trim #7252
Posted by "shirenchuang (via GitHub)" <gi...@apache.org>.
shirenchuang commented on code in PR #7258:
URL: https://github.com/apache/rocketmq/pull/7258#discussion_r1309958414
##########
client/src/main/java/org/apache/rocketmq/client/ClientConfig.java:
##########
@@ -215,7 +215,7 @@ public ClientConfig cloneClientConfig() {
public String getNamesrvAddr() {
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] joeCarf commented on a diff in pull request #7258: Enhancement getNamesrvAddr trim #7252
Posted by "joeCarf (via GitHub)" <gi...@apache.org>.
joeCarf commented on code in PR #7258:
URL: https://github.com/apache/rocketmq/pull/7258#discussion_r1305593441
##########
client/src/main/java/org/apache/rocketmq/client/ClientConfig.java:
##########
@@ -215,7 +215,7 @@ public ClientConfig cloneClientConfig() {
public String getNamesrvAddr() {
Review Comment:
will this be better?
```java
public String getNamesrvAddr() {
String trimmedNamesrvAddr = namesrvAddr.trim();
if (StringUtils.isNotEmpty(namesrvAddr) && NameServerAddressUtils.NAMESRV_ENDPOINT_PATTERN.matcher(trimmedNamesrvAddr).matches()) {
return NameServerAddressUtils.getNameSrvAddrFromNamesrvEndpoint(trimmedNamesrvAddr);
}
return namesrvAddr;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enhancement getNamesrvAddr trim #7252 [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #7258: Enhancement getNamesrvAddr trim #7252
URL: https://github.com/apache/rocketmq/pull/7258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enhancement getNamesrvAddr trim #7252 [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7258:
URL: https://github.com/apache/rocketmq/pull/7258#issuecomment-2330353032
This PR was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enhancement getNamesrvAddr trim #7252 [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7258:
URL: https://github.com/apache/rocketmq/pull/7258#issuecomment-2323080103
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org