You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "nkeywal (JIRA)" <ji...@apache.org> on 2012/11/15 21:05:13 UTC

[jira] [Created] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

nkeywal created HBASE-7168:
------------------------------

             Summary: [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
                 Key: HBASE-7168
                 URL: https://issues.apache.org/jira/browse/HBASE-7168
             Project: HBase
          Issue Type: Bug
          Components: scripts
    Affects Versions: 0.96.0
         Environment: dev
            Reporter: nkeywal
            Priority: Minor


When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505843#comment-13505843 ] 

Hudson commented on HBASE-7168:
-------------------------------

Integrated in HBase-TRUNK #3575 (See [https://builds.apache.org/job/HBase-TRUNK/3575/])
    HBASE-7168 ADD in the script called 'hbase', we don't check for errors when generating the classpath with mvn (Revision 1414868)

     Result = FAILURE
eclark : 
Files : 
* /hbase/trunk/bin/hbase

                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7168.v1.patch, HBASE-7168-ADD-0.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502960#comment-13502960 ] 

Hudson commented on HBASE-7168:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #271 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/271/])
    HBASE-7168 In the script called 'hbase', we don't check the errors when generating the classpath with mvn (Revision 1412565)

     Result = FAILURE
nkeywal : 
Files : 
* /hbase/trunk/bin/hbase

                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7168.v1.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502798#comment-13502798 ] 

nkeywal commented on HBASE-7168:
--------------------------------

Committed, thanks for the review, Elliott & Stack!

Note: I renamed the MAVEN_OPTIONS to MAVEN_OPTS as I saw at the last moment it was the naming pattern for the other options.
                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7168.v1.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502819#comment-13502819 ] 

Hudson commented on HBASE-7168:
-------------------------------

Integrated in HBase-TRUNK #3560 (See [https://builds.apache.org/job/HBase-TRUNK/3560/])
    HBASE-7168 In the script called 'hbase', we don't check the errors when generating the classpath with mvn (Revision 1412565)

     Result = FAILURE
nkeywal : 
Files : 
* /hbase/trunk/bin/hbase

                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7168.v1.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505712#comment-13505712 ] 

Elliott Clark commented on HBASE-7168:
--------------------------------------

Doesn't matter.  I can in a few mins.
                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7168.v1.patch, HBASE-7168-ADD-0.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504183#comment-13504183 ] 

stack commented on HBASE-7168:
------------------------------

+1 on this patch after talking to Elliott about 'portability' -- the paste command is probably not present on many *nx -- but after chatting, this fix is only for devs, lets just get this in for now.  Can address portability in another issue.
                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7168.v1.patch, HBASE-7168-ADD-0.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nkeywal resolved HBASE-7168.
----------------------------

       Resolution: Fixed
    Fix Version/s: 0.96.0
     Hadoop Flags: Reviewed
    
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7168.v1.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501901#comment-13501901 ] 

nkeywal commented on HBASE-7168:
--------------------------------

Proposal (it's a script modif, can't be tested on precommit). I will commit it after a or two day and a +1...
                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 7168.v1.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elliott Clark resolved HBASE-7168.
----------------------------------

    Resolution: Fixed

Committed the addendum in revision 1414868.
                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7168.v1.patch, HBASE-7168-ADD-0.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502223#comment-13502223 ] 

Elliott Clark commented on HBASE-7168:
--------------------------------------

+1 lgtm
                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 7168.v1.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nkeywal reassigned HBASE-7168:
------------------------------

    Assignee: nkeywal
    
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 7168.v1.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506079#comment-13506079 ] 

Hudson commented on HBASE-7168:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #278 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/278/])
    HBASE-7168 ADD in the script called 'hbase', we don't check for errors when generating the classpath with mvn (Revision 1414868)

     Result = FAILURE
eclark : 
Files : 
* /hbase/trunk/bin/hbase

                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7168.v1.patch, HBASE-7168-ADD-0.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elliott Clark reopened HBASE-7168:
----------------------------------

    
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7168.v1.patch, HBASE-7168-ADD-0.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elliott Clark updated HBASE-7168:
---------------------------------

    Attachment: HBASE-7168-ADD-0.patch

Seems like the maven_opts things were messing me up.  Also as I was adding more modules to hbase this was messed up as the ordering was not the one required. So here's a little addendum that fixed things for me.
                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7168.v1.patch, HBASE-7168-ADD-0.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504932#comment-13504932 ] 

nkeywal commented on HBASE-7168:
--------------------------------

I'm ok with that as well. Who's committing it?
                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7168.v1.patch, HBASE-7168-ADD-0.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nkeywal updated HBASE-7168:
---------------------------

    Attachment: 7168.v1.patch
    
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 7168.v1.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7168) [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502253#comment-13502253 ] 

stack commented on HBASE-7168:
------------------------------

+1
                
> [dev] in the script called 'hbase', we don't check for errors when generating the classpath with mvn
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7168
>                 URL: https://issues.apache.org/jira/browse/HBASE-7168
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.96.0
>         Environment: dev
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 7168.v1.patch
>
>
> When it happens, it's difficult to guess. Let's fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira