[GitHub] [opennlp] rzo1 commented on a diff in pull request #440: OPENNLP-1341: Fix make the conllu pos sample stream constructor public

[GitBox <gi...@apache.org>]

rzo1 commented on code in PR #440:
URL: https://github.com/apache/opennlp/pull/440#discussion_r1033483983


##########
opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluSentenceSampleStreamFactory.java:
##########
@@ -28,6 +28,9 @@
 import opennlp.tools.util.InputStreamFactory;
 import opennlp.tools.util.ObjectStream;
 
+/**
+ * <b>Note:</b> Do not use this class, internal use only!
+ */

Review Comment:
   These classes are in OpenNLP for some time now and the internal use only documentation was missing (until now). If we move these classes to an `internal` package, we might break users, which (falsely) relied on these classes being "open for the public". I like the suggestion by @mawiesne to make that change happen in a separate JIRA, so we can clearly document, that our users might be impacted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org