You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/12 05:58:47 UTC

[GitHub] [ozone] kaijchen commented on a diff in pull request #3406: HDDS-6734. ozone admin pipeline list CLI is not backward compatible

kaijchen commented on code in PR #3406:
URL: https://github.com/apache/ozone/pull/3406#discussion_r870976188


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/ReplicationFactor.java:
##########
@@ -76,14 +76,18 @@ public static HddsProtos.ReplicationFactor toProto(
     if (replicationFactor == null) {
       return null;
     }
-    switch (replicationFactor) {
+    return toProto(replicationFactor);

Review Comment:
   ```java
   return replicationFactor.toProto();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org