[Impala-ASF-CR] IMPALA-7446: enable missing buffer pool GC

["Tim Armstrong (Code Review)" <ge...@cloudera.org>]

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11350 )

Change subject: IMPALA-7446: enable missing buffer pool GC
......................................................................


Patch Set 3:

I need to get back to this one. I thought about it a bit and concluded that there was a more fundamental issue with the current integration between the reservation and memory trackers. 

The problem is that, when increasing reservation, we're comparing against the process limit, which includes free buffers etc but does not count existing unfulfilled reservations. Then when we're actually fulfilling the reservation by allocating new memory, we don't check to see if we're over the process memory limit.

So on one hand reservation increases might fail spuriously and on the other hand we might do buffer allocations that push us over the process limit.


-- 
To view, visit http://gerrit.cloudera.org:8080/11350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32400bda18a36f60cbe315fae715748d33677c10
Gerrit-Change-Number: 11350
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 21:53:00 +0000
Gerrit-HasComments: No