[GitHub] [james-project] chibenwa commented on a diff in pull request #997: JAMES-3765: Improve some IMAP commands (STORE, COPY, MOVE) performance

[GitBox <gi...@apache.org>]

chibenwa commented on code in PR #997:
URL: https://github.com/apache/james-project/pull/997#discussion_r870156101


##########
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraIndexTableHandler.java:
##########
@@ -129,8 +129,7 @@ public Mono<Void> updateIndexOnAdd(MailboxMessage message, CassandraId mailboxId
             .then();
     }
 
-    public Mono<Void> updateIndexOnAdd(Collection<MailboxMessage> messages, CassandraId mailboxId) {
-        int lowConcurrency = 2;
+    public Mono<Void> updateIndexOnAdd(Collection<MailboxMessage> messages, CassandraId mailboxId, int reactorConcurrency) {

Review Comment:
   Please use `fairConcurrency` variable like below and do not leak this detail outside.
   
   'Index' projections are not doing LWT thus enabling concurrency here will not result in CAS contension,



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org