You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/05/24 21:13:19 UTC
[GitHub] [netbeans] jlahoda opened a new pull request #2977: [NETBEANS-5704] when generating --patch-module option, also use the generated source roots.
jlahoda opened a new pull request #2977:
URL: https://github.com/apache/netbeans/pull/2977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2977: [NETBEANS-5704] when generating --patch-module option, also use the generated source roots.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2977:
URL: https://github.com/apache/netbeans/pull/2977#discussion_r640096725
##########
File path: java/maven/test/unit/src/org/netbeans/modules/maven/queries/UnitTestsCompilerOptionsQueryImplTest.java
##########
@@ -59,13 +60,19 @@ public void testNoCompilerPluginSpecified() throws Exception {
TestFileUtils.writeFile(wd,
"src/test/java/module-info.java",
"module test { requires testng; }\n");
+ TestFileUtils.writeFile(wd,
+ "target/generated-sources/java/test/Gen.java",
+ "package test;\n" +
+ "public class Gen {}\n");
FileObject testSource =
TestFileUtils.writeFile(wd,
"src/test/java/test/APITest.java",
"package test;\n" +
"public class APITest {}\n");
assertEquals(Arrays.asList("--patch-module",
- "test=" + FileUtil.toFile(wd.getFileObject("src/main/java")).getAbsolutePath()),
+ "test=" + FileUtil.toFile(wd.getFileObject("src/main/java")).toURI().getPath() +
Review comment:
Are paths or URIs expected for patch-module? If paths are expected, this will break for example for spaces ("%20" vs " "). The documentation seems to be thin on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on a change in pull request #2977: [NETBEANS-5704] when generating --patch-module option, also use the generated source roots.
Posted by GitBox <gi...@apache.org>.
jlahoda commented on a change in pull request #2977:
URL: https://github.com/apache/netbeans/pull/2977#discussion_r641266323
##########
File path: java/maven/test/unit/src/org/netbeans/modules/maven/queries/UnitTestsCompilerOptionsQueryImplTest.java
##########
@@ -59,13 +60,19 @@ public void testNoCompilerPluginSpecified() throws Exception {
TestFileUtils.writeFile(wd,
"src/test/java/module-info.java",
"module test { requires testng; }\n");
+ TestFileUtils.writeFile(wd,
+ "target/generated-sources/java/test/Gen.java",
+ "package test;\n" +
+ "public class Gen {}\n");
FileObject testSource =
TestFileUtils.writeFile(wd,
"src/test/java/test/APITest.java",
"package test;\n" +
"public class APITest {}\n");
assertEquals(Arrays.asList("--patch-module",
- "test=" + FileUtil.toFile(wd.getFileObject("src/main/java")).getAbsolutePath()),
+ "test=" + FileUtil.toFile(wd.getFileObject("src/main/java")).toURI().getPath() +
Review comment:
Paths are expected. It is a good comment on escaping, but isn't URI.getPath() returning un-escaped paths? (I've tweaked the test to actually use a space with paths.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2977: [NETBEANS-5704] when generating --patch-module option, also use the generated source roots.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2977:
URL: https://github.com/apache/netbeans/pull/2977#discussion_r641733162
##########
File path: java/maven/test/unit/src/org/netbeans/modules/maven/queries/UnitTestsCompilerOptionsQueryImplTest.java
##########
@@ -59,13 +60,19 @@ public void testNoCompilerPluginSpecified() throws Exception {
TestFileUtils.writeFile(wd,
"src/test/java/module-info.java",
"module test { requires testng; }\n");
+ TestFileUtils.writeFile(wd,
+ "target/generated-sources/java/test/Gen.java",
+ "package test;\n" +
+ "public class Gen {}\n");
FileObject testSource =
TestFileUtils.writeFile(wd,
"src/test/java/test/APITest.java",
"package test;\n" +
"public class APITest {}\n");
assertEquals(Arrays.asList("--patch-module",
- "test=" + FileUtil.toFile(wd.getFileObject("src/main/java")).getAbsolutePath()),
+ "test=" + FileUtil.toFile(wd.getFileObject("src/main/java")).toURI().getPath() +
Review comment:
You are right, I had to reiterate the difference between java.net.URL and java.net.URI and I had to realize that an URI is used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2977: [NETBEANS-5704] when generating --patch-module option, also use the generated source roots.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2977:
URL: https://github.com/apache/netbeans/pull/2977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2977: [NETBEANS-5704] when generating --patch-module option, also use the generated source roots.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2977:
URL: https://github.com/apache/netbeans/pull/2977#issuecomment-868773613
Lets get this in before it begins to bitrot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists