You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/08/01 07:15:44 UTC
[GitHub] [spark] beliefer opened a new pull request, #42256: [SPARK-41532][CONNECT][FOLLOWUP] Make the scala client using the same error class as python client.
beliefer opened a new pull request, #42256:
URL: https://github.com/apache/spark/pull/42256
### What changes were proposed in this pull request?
The python connect client define the error class in `error_classes.py`.
SESSION_NOT_SAME is an error class used to check the SparkSession of one dataset is the same the other dataset. Please refer [`error_classes.py` ](https://github.com/apache/spark/blob/546e39c5dabc1111243ab81b6238dc893d9993e0/python/pyspark/errors/error_classes.py#L678C1-L678C1)
But the scala connect client not the the same error class.
### Why are the changes needed?
This PR make the scala client using the same error class as python client.
### Does this PR introduce _any_ user-facing change?
'No'.
Just update the inner implementation.
### How was this patch tested?
Exists test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42256: [SPARK-41532][CONNECT][FOLLOWUP] Make the scala client using the same error class as python client.
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42256:
URL: https://github.com/apache/spark/pull/42256#issuecomment-1661491010
merged to master and branch-3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #42256: [SPARK-41532][CONNECT][FOLLOWUP] Make the scala client using the same error class as python client.
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #42256:
URL: https://github.com/apache/spark/pull/42256#issuecomment-1660222245
ping @zhengruifeng cc @HyukjinKwon @Hisoka-X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #42256: [SPARK-41532][CONNECT][FOLLOWUP] Make the scala client using the same error class as python client.
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #42256:
URL: https://github.com/apache/spark/pull/42256#issuecomment-1660223071
The CI failure is unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #42256: [SPARK-41532][CONNECT][FOLLOWUP] Make the scala client using the same error class as python client.
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42256: [SPARK-41532][CONNECT][FOLLOWUP] Make the scala client using the same error class as python client.
URL: https://github.com/apache/spark/pull/42256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org