You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jason Dere <jd...@hortonworks.com> on 2014/11/02 20:04:42 UTC
Review Request 27490: HIVE-8703 More Windows unit test fixes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27490/
-----------------------------------------------------------
Review request for hive and Thejas Nair.
Bugs: HIVE-8703
https://issues.apache.org/jira/browse/HIVE-8703
Repository: hive-git
Description
-------
- TestStorageBasedMetastoreAuthorizationReads - needs to call WindowsPathUtil.convertPathsFromWindowsToHdfs()
- TestAuthorizationApiAuthorizer - created role should have a name. This was causing TestLocationQueries to fail when run together because TestLocationQueries was unable to drop a role with a null name. This one fails on Unix as well.
- create_like.q, stats_noscan_2.q: system:hive.root wasn't working on Windows, change test to use system:test.tmp.dir.
- Also update the golden files for a few Windows-only .q file tests
Diffs
-----
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAuthorizationApiAuthorizer.java e65bf4d
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/StorageBasedMetastoreTestBase.java b59d2e1
ql/src/test/queries/clientpositive/create_like.q eb9f191
ql/src/test/queries/clientpositive/stats_noscan_2.q b106b30
ql/src/test/results/clientpositive/input_part10_win.q.out 92df63c
ql/src/test/results/clientpositive/load_dyn_part14_win.q.out 13b6c0b
ql/src/test/results/clientpositive/scriptfile1_win.q.out 1f84bd3
Diff: https://reviews.apache.org/r/27490/diff/
Testing
-------
Thanks,
Jason Dere
Re: Review Request 27490: HIVE-8703 More Windows unit test fixes
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27490/#review59611
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Nov. 3, 2014, 11:09 a.m., Jason Dere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27490/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 11:09 a.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-8703
> https://issues.apache.org/jira/browse/HIVE-8703
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> - TestStorageBasedMetastoreAuthorizationReads - needs to call WindowsPathUtil.convertPathsFromWindowsToHdfs()
> - TestAuthorizationApiAuthorizer - created role should have a name. This was causing TestLocationQueries to fail when run together because TestLocationQueries was unable to drop a role with a null name. This one fails on Unix as well.
> - create_like.q, stats_noscan_2.q: system:hive.root wasn't working on Windows, change test to use system:test.tmp.dir.
> - Also update the golden files for a few Windows-only .q file tests
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAuthorizationApiAuthorizer.java e65bf4d
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/StorageBasedMetastoreTestBase.java b59d2e1
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationDrops.java dfaa080
> ql/src/test/queries/clientpositive/create_like.q eb9f191
> ql/src/test/queries/clientpositive/stats_noscan_2.q b106b30
> ql/src/test/results/clientpositive/input_part10_win.q.out 92df63c
> ql/src/test/results/clientpositive/load_dyn_part14_win.q.out 13b6c0b
> ql/src/test/results/clientpositive/scriptfile1_win.q.out 1f84bd3
>
> Diff: https://reviews.apache.org/r/27490/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Dere
>
>
Re: Review Request 27490: HIVE-8703 More Windows unit test fixes
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27490/
-----------------------------------------------------------
(Updated Nov. 3, 2014, 11:09 a.m.)
Review request for hive and Thejas Nair.
Changes
-------
Fix TestStorageBasedMetastoreAuthorizationDrops. This test fails on Windows because sticky bit doesn't work on Windows filesystem. Change test to use MiniDFS which does support sticky bit.
Bugs: HIVE-8703
https://issues.apache.org/jira/browse/HIVE-8703
Repository: hive-git
Description
-------
- TestStorageBasedMetastoreAuthorizationReads - needs to call WindowsPathUtil.convertPathsFromWindowsToHdfs()
- TestAuthorizationApiAuthorizer - created role should have a name. This was causing TestLocationQueries to fail when run together because TestLocationQueries was unable to drop a role with a null name. This one fails on Unix as well.
- create_like.q, stats_noscan_2.q: system:hive.root wasn't working on Windows, change test to use system:test.tmp.dir.
- Also update the golden files for a few Windows-only .q file tests
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAuthorizationApiAuthorizer.java e65bf4d
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/StorageBasedMetastoreTestBase.java b59d2e1
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationDrops.java dfaa080
ql/src/test/queries/clientpositive/create_like.q eb9f191
ql/src/test/queries/clientpositive/stats_noscan_2.q b106b30
ql/src/test/results/clientpositive/input_part10_win.q.out 92df63c
ql/src/test/results/clientpositive/load_dyn_part14_win.q.out 13b6c0b
ql/src/test/results/clientpositive/scriptfile1_win.q.out 1f84bd3
Diff: https://reviews.apache.org/r/27490/diff/
Testing
-------
Thanks,
Jason Dere
Re: Review Request 27490: HIVE-8703 More Windows unit test fixes
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27490/#review59543
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Nov. 2, 2014, 7:05 p.m., Jason Dere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27490/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2014, 7:05 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-8703
> https://issues.apache.org/jira/browse/HIVE-8703
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> - TestStorageBasedMetastoreAuthorizationReads - needs to call WindowsPathUtil.convertPathsFromWindowsToHdfs()
> - TestAuthorizationApiAuthorizer - created role should have a name. This was causing TestLocationQueries to fail when run together because TestLocationQueries was unable to drop a role with a null name. This one fails on Unix as well.
> - create_like.q, stats_noscan_2.q: system:hive.root wasn't working on Windows, change test to use system:test.tmp.dir.
> - Also update the golden files for a few Windows-only .q file tests
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAuthorizationApiAuthorizer.java e65bf4d
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/StorageBasedMetastoreTestBase.java b59d2e1
> ql/src/test/queries/clientpositive/create_like.q eb9f191
> ql/src/test/queries/clientpositive/stats_noscan_2.q b106b30
> ql/src/test/results/clientpositive/input_part10_win.q.out 92df63c
> ql/src/test/results/clientpositive/load_dyn_part14_win.q.out 13b6c0b
> ql/src/test/results/clientpositive/scriptfile1_win.q.out 1f84bd3
>
> Diff: https://reviews.apache.org/r/27490/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Dere
>
>
Re: Review Request 27490: HIVE-8703 More Windows unit test fixes
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27490/
-----------------------------------------------------------
(Updated Nov. 2, 2014, 7:05 p.m.)
Review request for hive and Thejas Nair.
Bugs: HIVE-8703
https://issues.apache.org/jira/browse/HIVE-8703
Repository: hive-git
Description
-------
- TestStorageBasedMetastoreAuthorizationReads - needs to call WindowsPathUtil.convertPathsFromWindowsToHdfs()
- TestAuthorizationApiAuthorizer - created role should have a name. This was causing TestLocationQueries to fail when run together because TestLocationQueries was unable to drop a role with a null name. This one fails on Unix as well.
- create_like.q, stats_noscan_2.q: system:hive.root wasn't working on Windows, change test to use system:test.tmp.dir.
- Also update the golden files for a few Windows-only .q file tests
Diffs
-----
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAuthorizationApiAuthorizer.java e65bf4d
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/StorageBasedMetastoreTestBase.java b59d2e1
ql/src/test/queries/clientpositive/create_like.q eb9f191
ql/src/test/queries/clientpositive/stats_noscan_2.q b106b30
ql/src/test/results/clientpositive/input_part10_win.q.out 92df63c
ql/src/test/results/clientpositive/load_dyn_part14_win.q.out 13b6c0b
ql/src/test/results/clientpositive/scriptfile1_win.q.out 1f84bd3
Diff: https://reviews.apache.org/r/27490/diff/
Testing
-------
Thanks,
Jason Dere