You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/08/09 21:15:44 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #33266: Refactor: Simplify code in serialization

potiuk commented on code in PR #33266:
URL: https://github.com/apache/airflow/pull/33266#discussion_r1289205428


##########
airflow/serialization/serde.py:
##########
@@ -300,14 +300,13 @@ def _stringify(classname: str, version: int, value: T | None) -> str:
 
     s = f"{classname}@version={version}("
     if isinstance(value, _primitives):
-        s += f"{value})"

Review Comment:
   Hmm. That sounds like a bug .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org