You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Alessandro Presta (JIRA)" <ji...@apache.org> on 2012/07/07 17:28:33 UTC
[jira] [Created] (GIRAPH-242) HashMapVertex stores neighbor ids
twice
Alessandro Presta created GIRAPH-242:
----------------------------------------
Summary: HashMapVertex stores neighbor ids twice
Key: GIRAPH-242
URL: https://issues.apache.org/jira/browse/GIRAPH-242
Project: Giraph
Issue Type: Improvement
Components: graph
Reporter: Alessandro Presta
Assignee: Alessandro Presta
Priority: Minor
Attachments: GIRAPH-242.patch
The outgoing edges in a HashMapVertex are currently stored as a Map<I, Edge<I, E>>, where a Map<I, E> suffices.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-242) HashMapVertex stores neighbor ids
twice
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alessandro Presta updated GIRAPH-242:
-------------------------------------
Attachment: GIRAPH-242.patch
Rebased against current trunk.
> HashMapVertex stores neighbor ids twice
> ---------------------------------------
>
> Key: GIRAPH-242
> URL: https://issues.apache.org/jira/browse/GIRAPH-242
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-242.patch, GIRAPH-242.patch
>
>
> The outgoing edges in a HashMapVertex are currently stored as a Map<I, Edge<I, E>>, where a Map<I, E> suffices.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-242) HashMapVertex stores neighbor ids
twice
Posted by "Hyunsik Choi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409603#comment-13409603 ]
Hyunsik Choi commented on GIRAPH-242:
-------------------------------------
+1
Thank you for finding it. Certainly, Map<I,E> is sufficient to HashMapVertex.
I'll commit this tomorrow unless there are objections.
> HashMapVertex stores neighbor ids twice
> ---------------------------------------
>
> Key: GIRAPH-242
> URL: https://issues.apache.org/jira/browse/GIRAPH-242
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-242.patch
>
>
> The outgoing edges in a HashMapVertex are currently stored as a Map<I, Edge<I, E>>, where a Map<I, E> suffices.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-242) HashMapVertex stores neighbor ids
twice
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411365#comment-13411365 ]
Alessandro Presta commented on GIRAPH-242:
------------------------------------------
Thanks Hyunsik!
> HashMapVertex stores neighbor ids twice
> ---------------------------------------
>
> Key: GIRAPH-242
> URL: https://issues.apache.org/jira/browse/GIRAPH-242
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-242.patch, GIRAPH-242.patch
>
>
> The outgoing edges in a HashMapVertex are currently stored as a Map<I, Edge<I, E>>, where a Map<I, E> suffices.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-242) HashMapVertex stores neighbor ids
twice
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alessandro Presta updated GIRAPH-242:
-------------------------------------
Attachment: GIRAPH-242.patch
> HashMapVertex stores neighbor ids twice
> ---------------------------------------
>
> Key: GIRAPH-242
> URL: https://issues.apache.org/jira/browse/GIRAPH-242
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-242.patch
>
>
> The outgoing edges in a HashMapVertex are currently stored as a Map<I, Edge<I, E>>, where a Map<I, E> suffices.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-242) HashMapVertex stores neighbor ids
twice
Posted by "Jan van der Lugt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408839#comment-13408839 ]
Jan van der Lugt commented on GIRAPH-242:
-----------------------------------------
Well spotted. Always in favor of patches that actually reduce the size of the project :-)
> HashMapVertex stores neighbor ids twice
> ---------------------------------------
>
> Key: GIRAPH-242
> URL: https://issues.apache.org/jira/browse/GIRAPH-242
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-242.patch
>
>
> The outgoing edges in a HashMapVertex are currently stored as a Map<I, Edge<I, E>>, where a Map<I, E> suffices.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-242) HashMapVertex stores neighbor ids
twice
Posted by "Hyunsik Choi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410281#comment-13410281 ]
Hyunsik Choi commented on GIRAPH-242:
-------------------------------------
Could you please rebase the patch against the latest repository? This patch is conflict to GIRAPH-238 committed today.
> HashMapVertex stores neighbor ids twice
> ---------------------------------------
>
> Key: GIRAPH-242
> URL: https://issues.apache.org/jira/browse/GIRAPH-242
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-242.patch
>
>
> The outgoing edges in a HashMapVertex are currently stored as a Map<I, Edge<I, E>>, where a Map<I, E> suffices.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-242) HashMapVertex stores neighbor ids
twice
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411107#comment-13411107 ]
Hudson commented on GIRAPH-242:
-------------------------------
Integrated in Giraph-trunk-Commit #140 (See [https://builds.apache.org/job/Giraph-trunk-Commit/140/])
GIRAPH-242: HashMapVertex stores neighbor ids twice. Contributed by Alessandro Presta. (Revision 1359965)
Result = FAILURE
hyunsik : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359965
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/src/main/java/org/apache/giraph/graph/HashMapVertex.java
> HashMapVertex stores neighbor ids twice
> ---------------------------------------
>
> Key: GIRAPH-242
> URL: https://issues.apache.org/jira/browse/GIRAPH-242
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-242.patch, GIRAPH-242.patch
>
>
> The outgoing edges in a HashMapVertex are currently stored as a Map<I, Edge<I, E>>, where a Map<I, E> suffices.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-242) HashMapVertex stores neighbor ids
twice
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410094#comment-13410094 ]
Avery Ching commented on GIRAPH-242:
------------------------------------
Good find Alessandro. Hopefully no one is using HashMapVertex anyway though =).
> HashMapVertex stores neighbor ids twice
> ---------------------------------------
>
> Key: GIRAPH-242
> URL: https://issues.apache.org/jira/browse/GIRAPH-242
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-242.patch
>
>
> The outgoing edges in a HashMapVertex are currently stored as a Map<I, Edge<I, E>>, where a Map<I, E> suffices.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-242) HashMapVertex stores neighbor ids
twice
Posted by "Hyunsik Choi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411108#comment-13411108 ]
Hyunsik Choi commented on GIRAPH-242:
-------------------------------------
I verified the patch, and all unittest are passed in my local machine. I've just committed the patch. Thank you for your contribution.
However, the jenkins says the test are failed. I'm going to investigate the failure.
> HashMapVertex stores neighbor ids twice
> ---------------------------------------
>
> Key: GIRAPH-242
> URL: https://issues.apache.org/jira/browse/GIRAPH-242
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-242.patch, GIRAPH-242.patch
>
>
> The outgoing edges in a HashMapVertex are currently stored as a Map<I, Edge<I, E>>, where a Map<I, E> suffices.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira