You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gossip.apache.org by "Edward Capriolo (JIRA)" <ji...@apache.org> on 2016/07/15 17:21:20 UTC
[jira] [Commented] (GOSSIP-15) GossipManager:
TimeUnit.MILLISECONDS.sleep(1) is consuming resources.
[ https://issues.apache.org/jira/browse/GOSSIP-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379720#comment-15379720 ]
Edward Capriolo commented on GOSSIP-15:
---------------------------------------
ScheduledExecutor seems like a good fit.
> GossipManager: TimeUnit.MILLISECONDS.sleep(1) is consuming resources.
> ---------------------------------------------------------------------
>
> Key: GOSSIP-15
> URL: https://issues.apache.org/jira/browse/GOSSIP-15
> Project: Gossip
> Issue Type: Bug
> Reporter: Gary Dusbabek
>
> We need to find a better solution to what is essentially a busy wait.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Commented] (GOSSIP-15) GossipManager: TimeUnit.MILLISECONDS.sleep(1)
is consuming resources.
Posted by Chia-Hung Lin <cl...@googlemail.com>.
I've update the jira with updated pull request by following the current process.
Also a ticket for test failure, ShutdownDeadtimeTest, is created at [1].
Please let me know if anything I miss.
Thanks
[1]. https://issues.apache.org/jira/browse/GOSSIP-18
On 18/07/2016, Josh Elser <jo...@gmail.com> wrote:
> Filing a JIRA issue for the test failure would definitely be great.
>
> Thanks Chia-Hung!
>
> Chia-Hung Lin wrote:
>> I am interested in this issue. But searching the website[1] doesn't
>> find instruction on how to contribute so simply place my change at
>> [2].
>>
>> In addition to the change, I notice that `mvn clean package` sometimes
>> fails due to ShutdownDeadtimeTest test case. This happens even with a
>> clean checkout from incubator repos (git clone ...) so it looks not
>> related to my change. Perhaps I should open another ticket for this?
>>
>> org.junit.ComparisonFailure: ComparisonFailure expected:<[16]> but
>> was:<[2]>
>> at
>> org.apache.gossip.ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain(ShutdownDeadtimeTest.java:100)
>>
>> Results :
>>
>> Failed tests:
>> ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:100
>> ComparisonFailure expected:<[16]> but was:<[2]>
>> TenNodeThreeSeedTest.testAgain:52->abc:90 ComparisonFailure
>> expected:<[2]0> but was:<[]0>
>>
>> [1]. http://gossip.incubator.apache.org/
>> [2].
>> https://github.com/chlin501/incubator-gossip/commit/0a7d2ee12e54cdd4ccc171ea89ddb41af8b380e4
>>
>> On 16/07/2016, Edward Capriolo (JIRA)<ji...@apache.org> wrote:
>>> [
>>> https://issues.apache.org/jira/browse/GOSSIP-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379720#comment-15379720
>>> ]
>>>
>>> Edward Capriolo commented on GOSSIP-15:
>>> ---------------------------------------
>>>
>>> ScheduledExecutor seems like a good fit.
>>>
>>>> GossipManager: TimeUnit.MILLISECONDS.sleep(1) is consuming resources.
>>>> ---------------------------------------------------------------------
>>>>
>>>> Key: GOSSIP-15
>>>> URL: https://issues.apache.org/jira/browse/GOSSIP-15
>>>> Project: Gossip
>>>> Issue Type: Bug
>>>> Reporter: Gary Dusbabek
>>>>
>>>> We need to find a better solution to what is essentially a busy wait.
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.4#6332)
>>>
>
Re: [jira] [Commented] (GOSSIP-15) GossipManager: TimeUnit.MILLISECONDS.sleep(1)
is consuming resources.
Posted by Josh Elser <jo...@gmail.com>.
Filing a JIRA issue for the test failure would definitely be great.
Thanks Chia-Hung!
Chia-Hung Lin wrote:
> I am interested in this issue. But searching the website[1] doesn't
> find instruction on how to contribute so simply place my change at
> [2].
>
> In addition to the change, I notice that `mvn clean package` sometimes
> fails due to ShutdownDeadtimeTest test case. This happens even with a
> clean checkout from incubator repos (git clone ...) so it looks not
> related to my change. Perhaps I should open another ticket for this?
>
> org.junit.ComparisonFailure: ComparisonFailure expected:<[16]> but was:<[2]>
> at org.apache.gossip.ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain(ShutdownDeadtimeTest.java:100)
>
> Results :
>
> Failed tests:
> ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:100
> ComparisonFailure expected:<[16]> but was:<[2]>
> TenNodeThreeSeedTest.testAgain:52->abc:90 ComparisonFailure
> expected:<[2]0> but was:<[]0>
>
> [1]. http://gossip.incubator.apache.org/
> [2]. https://github.com/chlin501/incubator-gossip/commit/0a7d2ee12e54cdd4ccc171ea89ddb41af8b380e4
>
> On 16/07/2016, Edward Capriolo (JIRA)<ji...@apache.org> wrote:
>> [
>> https://issues.apache.org/jira/browse/GOSSIP-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379720#comment-15379720
>> ]
>>
>> Edward Capriolo commented on GOSSIP-15:
>> ---------------------------------------
>>
>> ScheduledExecutor seems like a good fit.
>>
>>> GossipManager: TimeUnit.MILLISECONDS.sleep(1) is consuming resources.
>>> ---------------------------------------------------------------------
>>>
>>> Key: GOSSIP-15
>>> URL: https://issues.apache.org/jira/browse/GOSSIP-15
>>> Project: Gossip
>>> Issue Type: Bug
>>> Reporter: Gary Dusbabek
>>>
>>> We need to find a better solution to what is essentially a busy wait.
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
Re: [jira] [Commented] (GOSSIP-15) GossipManager: TimeUnit.MILLISECONDS.sleep(1)
is consuming resources.
Posted by Edward Capriolo <ed...@gmail.com>.
Thanks for helping. Our normally process is:
fork
make branch with name of jjira ticket GOSSIP-15
Try to do commit (squashing others)
We need to get this onto the site for sure.
I will review your patch, Gary might as well because I am sure he has some
ideas.
On Sat, Jul 16, 2016 at 9:16 AM, Chia-Hung Lin <cl...@googlemail.com>
wrote:
> I am interested in this issue. But searching the website[1] doesn't
> find instruction on how to contribute so simply place my change at
> [2].
>
> In addition to the change, I notice that `mvn clean package` sometimes
> fails due to ShutdownDeadtimeTest test case. This happens even with a
> clean checkout from incubator repos (git clone ...) so it looks not
> related to my change. Perhaps I should open another ticket for this?
>
> org.junit.ComparisonFailure: ComparisonFailure expected:<[16]> but
> was:<[2]>
> at
> org.apache.gossip.ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain(ShutdownDeadtimeTest.java:100)
>
> Results :
>
> Failed tests:
> ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:100
> ComparisonFailure expected:<[16]> but was:<[2]>
> TenNodeThreeSeedTest.testAgain:52->abc:90 ComparisonFailure
> expected:<[2]0> but was:<[]0>
>
> [1]. http://gossip.incubator.apache.org/
> [2].
> https://github.com/chlin501/incubator-gossip/commit/0a7d2ee12e54cdd4ccc171ea89ddb41af8b380e4
>
> On 16/07/2016, Edward Capriolo (JIRA) <ji...@apache.org> wrote:
> >
> > [
> >
> https://issues.apache.org/jira/browse/GOSSIP-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379720#comment-15379720
> > ]
> >
> > Edward Capriolo commented on GOSSIP-15:
> > ---------------------------------------
> >
> > ScheduledExecutor seems like a good fit.
> >
> >> GossipManager: TimeUnit.MILLISECONDS.sleep(1) is consuming resources.
> >> ---------------------------------------------------------------------
> >>
> >> Key: GOSSIP-15
> >> URL: https://issues.apache.org/jira/browse/GOSSIP-15
> >> Project: Gossip
> >> Issue Type: Bug
> >> Reporter: Gary Dusbabek
> >>
> >> We need to find a better solution to what is essentially a busy wait.
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v6.3.4#6332)
> >
>
Re: [jira] [Commented] (GOSSIP-15) GossipManager: TimeUnit.MILLISECONDS.sleep(1)
is consuming resources.
Posted by Chia-Hung Lin <cl...@googlemail.com>.
I am interested in this issue. But searching the website[1] doesn't
find instruction on how to contribute so simply place my change at
[2].
In addition to the change, I notice that `mvn clean package` sometimes
fails due to ShutdownDeadtimeTest test case. This happens even with a
clean checkout from incubator repos (git clone ...) so it looks not
related to my change. Perhaps I should open another ticket for this?
org.junit.ComparisonFailure: ComparisonFailure expected:<[16]> but was:<[2]>
at org.apache.gossip.ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain(ShutdownDeadtimeTest.java:100)
Results :
Failed tests:
ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:100
ComparisonFailure expected:<[16]> but was:<[2]>
TenNodeThreeSeedTest.testAgain:52->abc:90 ComparisonFailure
expected:<[2]0> but was:<[]0>
[1]. http://gossip.incubator.apache.org/
[2]. https://github.com/chlin501/incubator-gossip/commit/0a7d2ee12e54cdd4ccc171ea89ddb41af8b380e4
On 16/07/2016, Edward Capriolo (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/GOSSIP-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379720#comment-15379720
> ]
>
> Edward Capriolo commented on GOSSIP-15:
> ---------------------------------------
>
> ScheduledExecutor seems like a good fit.
>
>> GossipManager: TimeUnit.MILLISECONDS.sleep(1) is consuming resources.
>> ---------------------------------------------------------------------
>>
>> Key: GOSSIP-15
>> URL: https://issues.apache.org/jira/browse/GOSSIP-15
>> Project: Gossip
>> Issue Type: Bug
>> Reporter: Gary Dusbabek
>>
>> We need to find a better solution to what is essentially a busy wait.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>