You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/14 17:31:09 UTC
[GitHub] [fineract-cn-mobile] EGOR-IND opened a new pull request #126: remove ripple effect from all non-functional cards
EGOR-IND opened a new pull request #126:
URL: https://github.com/apache/fineract-cn-mobile/pull/126
Fixes FINCN-255
https://user-images.githubusercontent.com/56648862/111077850-b2c69480-8518-11eb-8ca4-fef1eb3a3e25.mp4
In the above screen recording you can see that there is no ripple effect generating from taping on the cards. I showed only two cards but I resolved this issue from 6 different cards.
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
- [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything.
- [x] If you have multiple commits please combine them into one commit by squashing them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #126: remove ripple effect from all non-functional cards
Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #126:
URL: https://github.com/apache/fineract-cn-mobile/pull/126#issuecomment-802574093
> @EGOR-IND shouldn't we also implement this in ledger, accounts, tellers and products list items?
@PatelVatsalB21 actually they are clickable items even activity for ledger details is already made but the PR haven't merged yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] EGOR-IND edited a comment on pull request #126: remove ripple effect from all non-functional cards
Posted by GitBox <gi...@apache.org>.
EGOR-IND edited a comment on pull request #126:
URL: https://github.com/apache/fineract-cn-mobile/pull/126#issuecomment-802574093
> @EGOR-IND shouldn't we also implement this in ledger, accounts, tellers and products list items?
@PatelVatsalB21 actually they are clickable items even activity for ledger details is already made but the PR has't merged yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #126: remove ripple effect from all non-functional cards
Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #126:
URL: https://github.com/apache/fineract-cn-mobile/pull/126#issuecomment-798950445
@jawidMuhammadi Please review this when you have time:).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org