You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Pavel Dolgov (JIRA)" <ji...@apache.org> on 2006/12/04 17:12:22 UTC

[jira] Created: (HARMONY-2442) [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException

[classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException
-----------------------------------------------------------------------------------

                 Key: HARMONY-2442
                 URL: http://issues.apache.org/jira/browse/HARMONY-2442
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Pavel Dolgov
            Priority: Minor


Test case:
---------------------
import java.awt.Robot;

import junit.framework.TestCase;

public class TheTest extends TestCase {
	
	public static void main(String args[]) {
		junit.textui.TestRunner.run(TheTest.class);
	}
	
	public void testcase1() {
		try {
			new Robot(null);
			fail("IAE expected");
		} catch (IllegalArgumentException e) {
		} catch (Exception ex) {
			fail(ex.getClass().getName());
		}
	}
}


RI output:
----------------
.
Time: 0,04

OK (1 test)

Harmony output:
----------------
.F
Time: 0.5
There was 1 failure:
1) testcase1(TheTest)junit.framework.AssertionFailedError: java.lang.NullPointerException
	at TheTest.testcase1(TheTest.java:17)
	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
	at TheTest.main(TheTest.java:8)

FAILURES!!!
Tests run: 1,  Failures: 1,  Errors: 0



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-2442) [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess resolved HARMONY-2442.
-----------------------------------

    Resolution: Fixed
      Assignee: Mark Hindess

Applied patches in r495848.  I modified the test to let junit handle the exception to conform to project conventions.  Please confirm that the patches were applied as expected.


> [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException
> -----------------------------------------------------------------------------------
>
>                 Key: HARMONY-2442
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2442
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Pavel Dolgov
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Robot.patch, RobotTest.patch
>
>
> Test case:
> ---------------------
> import java.awt.Robot;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> 	
> 	public static void main(String args[]) {
> 		junit.textui.TestRunner.run(TheTest.class);
> 	}
> 	
> 	public void testcase1() {
> 		try {
> 			new Robot(null);
> 			fail("IAE expected");
> 		} catch (IllegalArgumentException e) {
> 		} catch (Exception ex) {
> 			fail(ex.getClass().getName());
> 		}
> 	}
> }
> RI output:
> ----------------
> .
> Time: 0,04
> OK (1 test)
> Harmony output:
> ----------------
> .F
> Time: 0.5
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: java.lang.NullPointerException
> 	at TheTest.testcase1(TheTest.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2442) [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2442?page=all ]

Andrey Pavlenko updated HARMONY-2442:
-------------------------------------

    Attachment: Robot.patch
                RobotTest.patch

Attaching patch and regression test.

> [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException
> -----------------------------------------------------------------------------------
>
>                 Key: HARMONY-2442
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2442
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Pavel Dolgov
>            Priority: Minor
>         Attachments: Robot.patch, RobotTest.patch
>
>
> Test case:
> ---------------------
> import java.awt.Robot;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> 	
> 	public static void main(String args[]) {
> 		junit.textui.TestRunner.run(TheTest.class);
> 	}
> 	
> 	public void testcase1() {
> 		try {
> 			new Robot(null);
> 			fail("IAE expected");
> 		} catch (IllegalArgumentException e) {
> 		} catch (Exception ex) {
> 			fail(ex.getClass().getName());
> 		}
> 	}
> }
> RI output:
> ----------------
> .
> Time: 0,04
> OK (1 test)
> Harmony output:
> ----------------
> .F
> Time: 0.5
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: java.lang.NullPointerException
> 	at TheTest.testcase1(TheTest.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-2442) [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess closed HARMONY-2442.
---------------------------------


Verified.  Thanks.

> [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException
> -----------------------------------------------------------------------------------
>
>                 Key: HARMONY-2442
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2442
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Pavel Dolgov
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Robot.patch, RobotTest.patch
>
>
> Test case:
> ---------------------
> import java.awt.Robot;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> 	
> 	public static void main(String args[]) {
> 		junit.textui.TestRunner.run(TheTest.class);
> 	}
> 	
> 	public void testcase1() {
> 		try {
> 			new Robot(null);
> 			fail("IAE expected");
> 		} catch (IllegalArgumentException e) {
> 		} catch (Exception ex) {
> 			fail(ex.getClass().getName());
> 		}
> 	}
> }
> RI output:
> ----------------
> .
> Time: 0,04
> OK (1 test)
> Harmony output:
> ----------------
> .F
> Time: 0.5
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: java.lang.NullPointerException
> 	at TheTest.testcase1(TheTest.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2442) [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465104 ] 

Andrey Pavlenko commented on HARMONY-2442:
------------------------------------------

Sorry, I hadn't updated the test. Now everything is ok, you can close the issue. 

> [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException
> -----------------------------------------------------------------------------------
>
>                 Key: HARMONY-2442
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2442
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Pavel Dolgov
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Robot.patch, RobotTest.patch
>
>
> Test case:
> ---------------------
> import java.awt.Robot;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> 	
> 	public static void main(String args[]) {
> 		junit.textui.TestRunner.run(TheTest.class);
> 	}
> 	
> 	public void testcase1() {
> 		try {
> 			new Robot(null);
> 			fail("IAE expected");
> 		} catch (IllegalArgumentException e) {
> 		} catch (Exception ex) {
> 			fail(ex.getClass().getName());
> 		}
> 	}
> }
> RI output:
> ----------------
> .
> Time: 0,04
> OK (1 test)
> Harmony output:
> ----------------
> .F
> Time: 0.5
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: java.lang.NullPointerException
> 	at TheTest.testcase1(TheTest.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2442) [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464986 ] 

Mark Hindess commented on HARMONY-2442:
---------------------------------------

Yes.  The test patch has been applied the string you searched for is two lines after the comment "// Regression test for HARMONY-2442".


> [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException
> -----------------------------------------------------------------------------------
>
>                 Key: HARMONY-2442
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2442
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Pavel Dolgov
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Robot.patch, RobotTest.patch
>
>
> Test case:
> ---------------------
> import java.awt.Robot;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> 	
> 	public static void main(String args[]) {
> 		junit.textui.TestRunner.run(TheTest.class);
> 	}
> 	
> 	public void testcase1() {
> 		try {
> 			new Robot(null);
> 			fail("IAE expected");
> 		} catch (IllegalArgumentException e) {
> 		} catch (Exception ex) {
> 			fail(ex.getClass().getName());
> 		}
> 	}
> }
> RI output:
> ----------------
> .
> Time: 0,04
> OK (1 test)
> Harmony output:
> ----------------
> .F
> Time: 0.5
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: java.lang.NullPointerException
> 	at TheTest.testcase1(TheTest.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2442) [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464947 ] 

Andrey Pavlenko commented on HARMONY-2442:
------------------------------------------

Mark, have you applied the patch for the test? I can't find new Robot(null); string in the test.

> [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException
> -----------------------------------------------------------------------------------
>
>                 Key: HARMONY-2442
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2442
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Pavel Dolgov
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Robot.patch, RobotTest.patch
>
>
> Test case:
> ---------------------
> import java.awt.Robot;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> 	
> 	public static void main(String args[]) {
> 		junit.textui.TestRunner.run(TheTest.class);
> 	}
> 	
> 	public void testcase1() {
> 		try {
> 			new Robot(null);
> 			fail("IAE expected");
> 		} catch (IllegalArgumentException e) {
> 		} catch (Exception ex) {
> 			fail(ex.getClass().getName());
> 		}
> 	}
> }
> RI output:
> ----------------
> .
> Time: 0,04
> OK (1 test)
> Harmony output:
> ----------------
> .F
> Time: 0.5
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: java.lang.NullPointerException
> 	at TheTest.testcase1(TheTest.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2442) [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Zakharov updated HARMONY-2442:
-------------------------------------

    Patch Info: [Patch Available]

> [classlib][awt] java.awt.Robot(null) throws NPE instead of IllegalArgumentException
> -----------------------------------------------------------------------------------
>
>                 Key: HARMONY-2442
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2442
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Pavel Dolgov
>            Priority: Minor
>         Attachments: Robot.patch, RobotTest.patch
>
>
> Test case:
> ---------------------
> import java.awt.Robot;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> 	
> 	public static void main(String args[]) {
> 		junit.textui.TestRunner.run(TheTest.class);
> 	}
> 	
> 	public void testcase1() {
> 		try {
> 			new Robot(null);
> 			fail("IAE expected");
> 		} catch (IllegalArgumentException e) {
> 		} catch (Exception ex) {
> 			fail(ex.getClass().getName());
> 		}
> 	}
> }
> RI output:
> ----------------
> .
> Time: 0,04
> OK (1 test)
> Harmony output:
> ----------------
> .F
> Time: 0.5
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: java.lang.NullPointerException
> 	at TheTest.testcase1(TheTest.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira