[GitHub] [ozone] adoroszlai commented on a diff in pull request #3217: HDDS-6458. Add erasure coding option in TestMiniOzoneChaosCluster

[GitBox <gi...@apache.org>]

adoroszlai commented on code in PR #3217:
URL: https://github.com/apache/ozone/pull/3217#discussion_r861229334


##########
hadoop-ozone/fault-injection-test/mini-chaos-tests/src/test/java/org/apache/hadoop/ozone/TestMiniChaosOzoneCluster.java:
##########
@@ -91,6 +98,16 @@
           "--failureInterval will be removed in later versions.")
   private static int failureInterval = 300; // 5 minute period between failures.
 
+  @Option(names = {"-r", "--replication-type"},

Review Comment:
   `-t` is already taken for number of threads.
   
   However, you can add the `FreonReplicationOptions` (which omits `-t` for the same purpose):
   
   https://github.com/apache/ozone/blob/c2512588322677afcb0118c9ccb0057f01b877b3/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OmKeyGenerator.java#L64-L65
   
   and then use it:
   
   https://github.com/apache/ozone/blob/c2512588322677afcb0118c9ccb0057f01b877b3/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/CreateBucketHandler.java#L128-L129
   
   (adapt to this class by replacing `getConf()` with `configuration`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org