Re: svn commit: r734260 - /httpd/apreq/trunk/library/module_cgi.c

[Issac Goldstand <ma...@beamartyr.net>]

Right.  IIRC, that was one of the patches that we needed to fix for
maintainer mode last night.  I knew it was complicated to begin with for
a reason :)

joes@apache.org wrote:
> Author: joes
> Date: Tue Jan 13 14:30:23 2009
> New Revision: 734260
>
> URL: http://svn.apache.org/viewvc?rev=734260&view=rev
> Log:
> without this patch we get segfaults
> if we enter an empty line at the prompts
>
> Modified:
>     httpd/apreq/trunk/library/module_cgi.c
>
> Modified: httpd/apreq/trunk/library/module_cgi.c
> URL: http://svn.apache.org/viewvc/httpd/apreq/trunk/library/module_cgi.c?rev=734260&r1=734259&r2=734260&view=diff
> ==============================================================================
> --- httpd/apreq/trunk/library/module_cgi.c (original)
> +++ httpd/apreq/trunk/library/module_cgi.c Tue Jan 13 14:30:23 2009
> @@ -249,7 +249,7 @@
>  /*        return NULL; */
>      }
>  
> -    if (strcmp(defval, nullstr))
> +    if (defval != nullstr)
>          return apr_pstrdup(handle->pool, defval);
>  
>      return NULL;
>
>